bpo-40164: Update Windows to OpenSSL 1.1.1f #19359

zooba · 2020-04-04T12:14:34Z

https://bugs.python.org/issue40164

miss-islington · 2020-04-04T14:19:12Z

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington · 2020-04-04T14:19:17Z

Sorry, @zooba, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a1d4dbdfc78e3aed4c245e1810ef24eaa4e744c2 3.8

miss-islington · 2020-04-04T14:19:19Z

Sorry @zooba, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a1d4dbdfc78e3aed4c245e1810ef24eaa4e744c2 3.7

miss-islington · 2020-04-04T14:19:58Z

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington · 2020-04-04T14:19:58Z

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington · 2020-04-04T14:20:01Z

Sorry, @zooba, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a1d4dbdfc78e3aed4c245e1810ef24eaa4e744c2 3.7

miss-islington · 2020-04-04T14:20:03Z

Sorry @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a1d4dbdfc78e3aed4c245e1810ef24eaa4e744c2 3.8

bedevere-bot · 2020-04-04T14:22:25Z

GH-19361 is a backport of this pull request to the 3.8 branch.

bedevere-bot · 2020-04-04T14:24:36Z

GH-19362 is a backport of this pull request to the 3.7 branch.

bedevere-bot · 2020-04-04T15:06:00Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.8 has failed when building commit 37126e7.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/162/builds/229) and take a look at the build logs.
Check if the failure is related to this commit (37126e7) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/162/builds/229

Failed tests:

test_zipimport

Failed subtests:

testBoth - test.test_zipimport.CompressedZipImportTestCase
testBoth - test.test_zipimport.UncompressedZipImportTestCase
testGetCompiledSource - test.test_zipimport.UncompressedZipImportTestCase
testGetCompiledSource - test.test_zipimport.CompressedZipImportTestCase

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

402 tests OK.

10 slowest tests:

test_concurrent_futures: 3 min 6 sec
test_multiprocessing_spawn: 2 min 15 sec
test_tokenize: 1 min 34 sec
test_multiprocessing_forkserver: 1 min 26 sec
test_tools: 1 min 18 sec
test_multiprocessing_fork: 1 min 11 sec
test_lib2to3: 51.2 sec
test_asyncio: 48.6 sec
test_io: 42.0 sec
test_nntplib: 33.8 sec

1 test failed:
test_zipimport

20 tests skipped:
test_devpoll test_gdb test_idle test_ioctl test_kqueue test_msilib
test_ossaudiodev test_smtpnet test_ssl test_startfile test_tcl
test_tix test_tk test_ttk_guionly test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_zipimport

Total duration: 15 min 7 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/root/buildarea/3.8.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 592, in testGetCompiledSource
    self.doTest(pyc_ext, files, TESTMOD, call=self.assertModuleSource)
  File "/root/buildarea/3.8.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 146, in doTest
    self.assertEqual(file, os.path.join(TEMP_ZIP,
AssertionError: '/roo[61 chars]_1456/test_python_worker_14750/junk95142.zip/ziptestmodule.py' != '/roo[61 chars]_1456/test_python_worker_14750/junk95142.zip/ziptestmodule.pyc'
- /root/buildarea/3.8.angelico-debian-amd64/build/build/test_python_1456/test_python_worker_14750/junk95142.zip/ziptestmodule.py
+ /root/buildarea/3.8.angelico-debian-amd64/build/build/test_python_1456/test_python_worker_14750/junk95142.zip/ziptestmodule.pyc
?                                                                                                                               +


Traceback (test.test_zipimport.UncompressedZipImportTestCase) ... ok


Traceback (test.test_zipimport.CompressedZipImportTestCase) ... ok


Traceback (most recent call last):
  File "/root/buildarea/3.8.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 592, in testGetCompiledSource
    self.doTest(pyc_ext, files, TESTMOD, call=self.assertModuleSource)
  File "/root/buildarea/3.8.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 146, in doTest
    self.assertEqual(file, os.path.join(TEMP_ZIP,
AssertionError: '/roo[36 chars]4/build/build/test_python_1456/junk95142.zip/ziptestmodule.py' != '/roo[36 chars]4/build/build/test_python_1456/junk95142.zip/ziptestmodule.pyc'
- /root/buildarea/3.8.angelico-debian-amd64/build/build/test_python_1456/junk95142.zip/ziptestmodule.py
+ /root/buildarea/3.8.angelico-debian-amd64/build/build/test_python_1456/junk95142.zip/ziptestmodule.pyc
?                                                                                                      +


Traceback (most recent call last):
  File "/root/buildarea/3.8.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 192, in testBoth
    self.doTest(pyc_ext, files, TESTMOD)
  File "/root/buildarea/3.8.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 146, in doTest
    self.assertEqual(file, os.path.join(TEMP_ZIP,
AssertionError: '/roo[61 chars]_1456/test_python_worker_14750/junk95142.zip/ziptestmodule.py' != '/roo[61 chars]_1456/test_python_worker_14750/junk95142.zip/ziptestmodule.pyc'
- /root/buildarea/3.8.angelico-debian-amd64/build/build/test_python_1456/test_python_worker_14750/junk95142.zip/ziptestmodule.py
+ /root/buildarea/3.8.angelico-debian-amd64/build/build/test_python_1456/test_python_worker_14750/junk95142.zip/ziptestmodule.pyc
?                                                                                                                               +


Traceback (most recent call last):
  File "/root/buildarea/3.8.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 192, in testBoth
    self.doTest(pyc_ext, files, TESTMOD)
  File "/root/buildarea/3.8.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 146, in doTest
    self.assertEqual(file, os.path.join(TEMP_ZIP,
AssertionError: '/roo[36 chars]4/build/build/test_python_1456/junk95142.zip/ziptestmodule.py' != '/roo[36 chars]4/build/build/test_python_1456/junk95142.zip/ziptestmodule.pyc'
- /root/buildarea/3.8.angelico-debian-amd64/build/build/test_python_1456/junk95142.zip/ziptestmodule.py
+ /root/buildarea/3.8.angelico-debian-amd64/build/build/test_python_1456/junk95142.zip/ziptestmodule.pyc
?                                                                                                      +

bedevere-bot · 2020-04-04T15:21:18Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.7 has failed when building commit e7a47c2.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/3/builds/145) and take a look at the build logs.
Check if the failure is related to this commit (e7a47c2) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/3/builds/145

Failed tests:

test_zipimport

Failed subtests:

testBoth - test.test_zipimport.CompressedZipImportTestCase
testBoth - test.test_zipimport.UncompressedZipImportTestCase
testGetCompiledSource - test.test_zipimport.UncompressedZipImportTestCase
testGetCompiledSource - test.test_zipimport.CompressedZipImportTestCase

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

395 tests OK.

10 slowest tests:

test_concurrent_futures: 2 min 49 sec
test_multiprocessing_spawn: 2 min 14 sec
test_multiprocessing_forkserver: 1 min 28 sec
test_tokenize: 1 min 12 sec
test_multiprocessing_fork: 1 min 10 sec
test_lib2to3: 59.3 sec
test_tools: 56.2 sec
test_asyncio: 47.7 sec
test_io: 41.2 sec
test_nntplib: 33.0 sec

1 test failed:
test_zipimport

20 tests skipped:
test_devpoll test_gdb test_idle test_ioctl test_kqueue test_msilib
test_ossaudiodev test_smtpnet test_ssl test_startfile test_tcl
test_tix test_tk test_ttk_guionly test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_zipimport

Total duration: 13 min 13 sec

Click to see traceback logs

Traceback (test.test_zipimport.UncompressedZipImportTestCase) ... ok


Traceback (test.test_zipimport.CompressedZipImportTestCase) ... ok


Traceback (most recent call last):
  File "/root/buildarea/3.7.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 601, in testGetCompiledSource
    self.doTest(pyc_ext, files, TESTMOD, call=self.assertModuleSource)
  File "/root/buildarea/3.7.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 143, in doTest
    *modules) + expected_ext)
AssertionError: '/roo[61 chars]_30314/test_python_worker_5361/junk95142.zip/ziptestmodule.py' != '/roo[61 chars]_30314/test_python_worker_5361/junk95142.zip/ziptestmodule.pyc'
- /root/buildarea/3.7.angelico-debian-amd64/build/build/test_python_30314/test_python_worker_5361/junk95142.zip/ziptestmodule.py
+ /root/buildarea/3.7.angelico-debian-amd64/build/build/test_python_30314/test_python_worker_5361/junk95142.zip/ziptestmodule.pyc
?                                                                                                                               +


Traceback (most recent call last):
  File "/root/buildarea/3.7.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 188, in testBoth
    self.doTest(pyc_ext, files, TESTMOD)
  File "/root/buildarea/3.7.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 143, in doTest
    *modules) + expected_ext)
AssertionError: '/roo[61 chars]_30314/test_python_worker_5361/junk95142.zip/ziptestmodule.py' != '/roo[61 chars]_30314/test_python_worker_5361/junk95142.zip/ziptestmodule.pyc'
- /root/buildarea/3.7.angelico-debian-amd64/build/build/test_python_30314/test_python_worker_5361/junk95142.zip/ziptestmodule.py
+ /root/buildarea/3.7.angelico-debian-amd64/build/build/test_python_30314/test_python_worker_5361/junk95142.zip/ziptestmodule.pyc
?                                                                                                                               +


Traceback (most recent call last):
  File "/root/buildarea/3.7.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 188, in testBoth
    self.doTest(pyc_ext, files, TESTMOD)
  File "/root/buildarea/3.7.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 143, in doTest
    *modules) + expected_ext)
AssertionError: '/roo[37 chars]/build/build/test_python_30314/junk95142.zip/ziptestmodule.py' != '/roo[37 chars]/build/build/test_python_30314/junk95142.zip/ziptestmodule.pyc'
- /root/buildarea/3.7.angelico-debian-amd64/build/build/test_python_30314/junk95142.zip/ziptestmodule.py
+ /root/buildarea/3.7.angelico-debian-amd64/build/build/test_python_30314/junk95142.zip/ziptestmodule.pyc
?                                                                                                       +


Traceback (most recent call last):
  File "/root/buildarea/3.7.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 601, in testGetCompiledSource
    self.doTest(pyc_ext, files, TESTMOD, call=self.assertModuleSource)
  File "/root/buildarea/3.7.angelico-debian-amd64/build/Lib/test/test_zipimport.py", line 143, in doTest
    *modules) + expected_ext)
AssertionError: '/roo[37 chars]/build/build/test_python_30314/junk95142.zip/ziptestmodule.py' != '/roo[37 chars]/build/build/test_python_30314/junk95142.zip/ziptestmodule.pyc'
- /root/buildarea/3.7.angelico-debian-amd64/build/build/test_python_30314/junk95142.zip/ziptestmodule.py
+ /root/buildarea/3.7.angelico-debian-amd64/build/build/test_python_30314/junk95142.zip/ziptestmodule.pyc
?                                                                                                       +

bpo-40164: Update Windows to OpenSSL 1.1.1f

307b2ec

zooba added OS-windows needs backport to 3.7 labels Apr 4, 2020

zooba requested a review from a team as a code owner April 4, 2020 12:14

the-knights-who-say-ni added the CLA signed label Apr 4, 2020

bedevere-bot added the awaiting core review label Apr 4, 2020

zooba merged commit a1d4dbd into python:master Apr 4, 2020

bedevere-bot removed the awaiting core review label Apr 4, 2020

zooba deleted the bpo-40164 branch April 4, 2020 14:19

miss-islington assigned zooba Apr 4, 2020

zooba added needs backport to 3.7 and removed needs backport to 3.7 labels Apr 4, 2020

zooba added a commit to zooba/cpython that referenced this pull request Apr 4, 2020

bpo-40164: Update Windows to OpenSSL 1.1.1f (pythonGH-19359)

cc57669

bedevere-bot removed the needs backport to 3.8 label Apr 4, 2020

zooba added a commit to zooba/cpython that referenced this pull request Apr 4, 2020

bpo-40164: Update Windows to OpenSSL 1.1.1f (pythonGH-19359)

403e0e4

bedevere-bot removed the needs backport to 3.7 label Apr 4, 2020

zooba added a commit that referenced this pull request Apr 4, 2020

bpo-40164: Update Windows to OpenSSL 1.1.1f (GH-19359)

37126e7

zooba added a commit that referenced this pull request Apr 4, 2020

bpo-40164: Update Windows to OpenSSL 1.1.1f (GH-19359)

e7a47c2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-40164: Update Windows to OpenSSL 1.1.1f #19359

bpo-40164: Update Windows to OpenSSL 1.1.1f #19359

zooba commented Apr 4, 2020 •

edited by bedevere-bot

Loading

miss-islington commented Apr 4, 2020

miss-islington commented Apr 4, 2020

miss-islington commented Apr 4, 2020

miss-islington commented Apr 4, 2020

miss-islington commented Apr 4, 2020

miss-islington commented Apr 4, 2020

miss-islington commented Apr 4, 2020

bedevere-bot commented Apr 4, 2020

bedevere-bot commented Apr 4, 2020

bedevere-bot commented Apr 4, 2020

bedevere-bot commented Apr 4, 2020

bpo-40164: Update Windows to OpenSSL 1.1.1f #19359

bpo-40164: Update Windows to OpenSSL 1.1.1f #19359

Conversation

zooba commented Apr 4, 2020 • edited by bedevere-bot Loading

miss-islington commented Apr 4, 2020

miss-islington commented Apr 4, 2020

miss-islington commented Apr 4, 2020

miss-islington commented Apr 4, 2020

miss-islington commented Apr 4, 2020

miss-islington commented Apr 4, 2020

miss-islington commented Apr 4, 2020

bedevere-bot commented Apr 4, 2020

bedevere-bot commented Apr 4, 2020

bedevere-bot commented Apr 4, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Apr 4, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

zooba commented Apr 4, 2020 •

edited by bedevere-bot

Loading