Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-27635: Fix pickle documentation about __new__ not being called. #19269

Merged
merged 4 commits into from
Apr 18, 2020
Merged

bpo-27635: Fix pickle documentation about __new__ not being called. #19269

merged 4 commits into from
Apr 18, 2020

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Apr 1, 2020 •
edited by miss-islington
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 1, 2020
@furkanonder furkanonder changed the title update pickle documentation bpo-27635:update pickle documentation Apr 1, 2020
@pitrou pitrou changed the title bpo-27635:update pickle documentation bpo-27635: Fix pickle documentation about __new__ not being called. Apr 18, 2020
pitrou
pitrou approved these changes Apr 18, 2020
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I improved the wording and will merge if CI passes.

@miss-islington
Copy link
Contributor

@furkanonder: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@furkanonder: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor

@furkanonder: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 482259d into python:master Apr 18, 2020
@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

@miss-islington
Copy link
Contributor

Thanks @furkanonder for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 18, 2020
@furkanonder @miss-islington
bpo-27635: Fix pickle documentation about __new__ not being called. (…
fffed00 
…pythonGH-19269)

Automerge-Triggered-By: @pitrou
(cherry picked from commit 482259d)

Co-authored-by: Furkan Önder <furkantahaonder@gmail.com>
@bedevere-bot
Copy link

GH-19585 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-19586 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 18, 2020
@furkanonder @miss-islington
bpo-27635: Fix pickle documentation about __new__ not being called. (…
91d0157 
…pythonGH-19269)

Automerge-Triggered-By: @pitrou
(cherry picked from commit 482259d)

Co-authored-by: Furkan Önder <furkantahaonder@gmail.com>
miss-islington added a commit that referenced this pull request Apr 18, 2020
@miss-islington @furkanonder
bpo-27635: Fix pickle documentation about __new__ not being called. (…
0abb548 
…GH-19269)

Automerge-Triggered-By: @pitrou
(cherry picked from commit 482259d)

Co-authored-by: Furkan Önder <furkantahaonder@gmail.com>
miss-islington added a commit that referenced this pull request Apr 18, 2020
@miss-islington @furkanonder
bpo-27635: Fix pickle documentation about __new__ not being called. (…
020f2aa 
…GH-19269)

Automerge-Triggered-By: @pitrou
(cherry picked from commit 482259d)

Co-authored-by: Furkan Önder <furkantahaonder@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@furkanonder @miss-islington @bedevere-bot @pitrou @the-knights-who-say-ni