Skip to content

bpo-29418: Implement inspect.ismethodwrapper and fix inspect.isroutine for cases where methodwrapper is given #19261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Feb 16, 2022
Merged

bpo-29418: Implement inspect.ismethodwrapper and fix inspect.isroutine for cases where methodwrapper is given #19261

merged 18 commits into from
Feb 16, 2022

Conversation

hakancelikdev
Copy link
Contributor

@hakancelikdev hakancelikdev commented Mar 31, 2020 •
edited by miss-islington
Loading

https://bugs.python.org/issue29418

Automerge-Triggered-By: GH:isidentical

@hakancelikdev hakancelikdev changed the title bpo-29418: Fix this issue, add new function named ismethodwrapper and more test write to isroutine function of inspect module bpo-29418: Fix this issue, add new function named ismethodwrapper. Mar 31, 2020
@hakancelikdev hakancelikdev changed the title bpo-29418: Fix this issue, add new function named ismethodwrapper. bpo-29418: Fix, return True if the object is a method-wrapper add new function named ismethodwrapper Mar 31, 2020
@isidentical isidentical requested a review from 1st1 April 16, 2020 10:42
@hakancelikdev hakancelikdev changed the title bpo-29418: Fix, return True if the object is a method-wrapper add new function named ismethodwrapper Implement inspect.ismethodwrapper and fix inspect.isroutine for cases where methodwrapper is given Apr 17, 2020
@hakancelikdev hakancelikdev changed the title Implement inspect.ismethodwrapper and fix inspect.isroutine for cases where methodwrapper is given bpo-29418: Implement inspect.ismethodwrapper and fix inspect.isroutine for cases where methodwrapper is given Apr 17, 2020
taleinat
taleinat requested changes Sep 26, 2020
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good! I only have a few minor requests.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hakancelikdev
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

taleinat
taleinat reviewed Sep 28, 2020
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! A couple of small suggestions.

@hakancelikdev
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

@hakancelikdev
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

isidentical
isidentical approved these changes Feb 15, 2022
View reviewed changes
hakancelikdev and others added 2 commits February 15, 2022 23:41
@hakancelikdev @isidentical
Update Doc/whatsnew/3.10.rst
d7e2f16 
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
@hakancelikdev @isidentical
Update Lib/inspect.py
fd03838 
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
asvetlov
asvetlov reviewed Feb 16, 2022
View reviewed changes
asvetlov
asvetlov reviewed Feb 16, 2022
View reviewed changes
asvetlov
asvetlov approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington
Copy link
Contributor

@hakancelik96: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@hakancelik96: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 562c13f into python:main Feb 16, 2022
@hakancelikdev hakancelikdev deleted the bpo-29418 branch February 16, 2022 19:40
@hakancelikdev hakancelikdev mentioned this pull request Feb 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@isidentical isidentical isidentical approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@taleinat taleinat Awaiting requested review from taleinat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hakancelikdev @bedevere-bot @miss-islington @asvetlov @taleinat @isidentical @the-knights-who-say-ni