bpo-39924: handle missing os functions more consistently in pathlib #19220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, this needs to merged or rebase with git master to solve conflicts. |
|
@barneygale, please address the review question and resolve the merge conflict. Thank you! |
barneygale
force-pushed
the
bpo-39924-pathlib-accessor-symlink-tidy
branch
from
9b976e3 to
f614e1a
Compare
|
Removed the Windows version check and rebased. |
barneygale
force-pushed
the
bpo-39924-pathlib-accessor-symlink-tidy
branch
from
f614e1a to
4f7fa9f
Compare
|
@pitrou I've rebased this and I believe it's ready to merge! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes
_NormalAccessorhandle missingosfunctions consistently. The specific functions which may be unavailable are:os.lchmod()os.link()os.symlink()os.readlink()Only user-facing change is that you'll now get a
NotImplementedErrorrather than anAttributeErrorwhenpathlibhits_Accessor.readlink()andos.readlinkdoesn't exist.https://bugs.python.org/issue39924