Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38972: Link to instructions to change PowerShell execution policy… #19131

Merged
merged 4 commits into from
Apr 2, 2020

Conversation

d3r3kk
Copy link
Contributor

@d3r3kk d3r3kk commented Mar 24, 2020

… for venv activation

Add proposed documentation for venv + Windows + Powershell.

This change:

  • Adds details on Set-ExecutionPolicy to venv site documenation.
  • Also adds the same detail to the Activate.ps1 script itself as a .Note. You can see this if you use Get-Help Activation.ps1 -Full.

https://bugs.python.org/issue38972

@d3r3kk
Copy link
Contributor Author

d3r3kk commented Mar 24, 2020

Not sure this change warrants a news entry?

Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately docs CI is failing.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@d3r3kk d3r3kk closed this Mar 31, 2020
@d3r3kk
Copy link
Contributor Author

d3r3kk commented Mar 31, 2020

Reopen to see if the CI failing issue is still affecting my PR.

@d3r3kk d3r3kk reopened this Mar 31, 2020
@brettcannon
Copy link
Member

@d3r3kk looks like an Ubuntu server is done that serves some files needed to build things.

@d3r3kk
Copy link
Contributor Author

d3r3kk commented Apr 1, 2020

Change seems decent other than the Ubuntu package service on Azure... 🤦‍♂️

@d3r3kk d3r3kk reopened this Apr 1, 2020
@brettcannon brettcannon self-requested a review April 1, 2020 17:22
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly fixing capitalization and using a fwlink instead of PS 7-specific link.

d3r3kk and others added 4 commits April 1, 2020 20:28
… for venv activation

Add proposed documentation for venv + Windows + Powershell

- add to venv site documenation.
- add to the Activate.ps1 script itself.
@d3r3kk d3r3kk requested a review from brettcannon April 2, 2020 05:49
@brettcannon brettcannon added needs backport to 3.7 docs Documentation in the Doc dir labels Apr 2, 2020
@brettcannon brettcannon merged commit 45217af into python:master Apr 2, 2020
@miss-islington
Copy link
Contributor

Thanks @d3r3kk for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 2, 2020
…pythonGH-19131)

(cherry picked from commit 45217af)

Co-authored-by: Derek Keeler <d3r3kk@users.noreply.github.com>
@bedevere-bot
Copy link

GH-19311 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

Sorry, @d3r3kk and @brettcannon, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 45217af29c7f380089af17beb48a5ea0560bbb9d 3.7

miss-islington added a commit that referenced this pull request Apr 2, 2020
…GH-19131)

(cherry picked from commit 45217af)

Co-authored-by: Derek Keeler <d3r3kk@users.noreply.github.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Non-Debug 3.8 has failed when building commit b7345c2.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/173/builds/185) and take a look at the build logs.
  4. Check if the failure is related to this commit (b7345c2) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/173/builds/185

Failed tests:

  • test_compile
  • test_asyncio

Failed subtests:

  • test_create_server_ssl_verified - test.test_asyncio.test_events.KqueueEventLoopTests
  • test_run_until_complete - test.test_asyncio.test_events.PollEventLoopTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

403 tests OK.

10 slowest tests:

  • test_multiprocessing_spawn: 4 min 44 sec
  • test_tokenize: 3 min 28 sec
  • test_concurrent_futures: 3 min 26 sec
  • test_tools: 2 min 53 sec
  • test_lib2to3: 2 min 38 sec
  • test_multiprocessing_forkserver: 2 min 25 sec
  • test_asyncio: 2 min 14 sec
  • test_io: 1 min 45 sec
  • test_multiprocessing_fork: 1 min 40 sec
  • test_pickle: 1 min 12 sec

1 test failed:
test_asyncio

19 tests skipped:
test_dbm_gnu test_devpoll test_epoll test_idle test_ioctl
test_msilib test_ossaudiodev test_spwd test_startfile test_tcl
test_tix test_tk test_ttk_guionly test_ttk_textonly test_turtle
test_winconsoleio test_winreg test_winsound test_zipfile64

2 re-run tests:
test_asyncio test_compile

Total duration: 16 min 48 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-9e36.nondebug/build/Lib/test/test_asyncio/test_events.py", line 275, in test_run_until_complete
    self.assertTrue(0.08 <= t1-t0 <= 0.8, t1-t0)
AssertionError: False is not true : 1.0404219990014099


Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.8.koobs-freebsd-9e36.nondebug/build/Lib/test/test_asyncio/test_events.py", line 1105, in test_create_server_ssl_verified
    proto.transport.close()
AttributeError: 'NoneType' object has no attribute 'close'

@d3r3kk d3r3kk deleted the ps_doc_38972 branch April 3, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants