Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40024: Update xxxxmodule to use PyModule_AddType. #19119

Merged
merged 16 commits into from
Mar 24, 2020
Merged

bpo-40024: Update xxxxmodule to use PyModule_AddType. #19119

merged 16 commits into from
Mar 24, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Mar 23, 2020 •
edited by bedevere-bot
Loading

@corona10 corona10 requested a review from vstinner March 23, 2020 17:03
pganssle
pganssle reviewed Mar 23, 2020
View reviewed changes
dimaqq
dimaqq reviewed Mar 24, 2020
View reviewed changes
@corona10 corona10 changed the title bpo-40024: Update xxxxmodule to use PyModule_AddType. [WIP] bpo-40024: Update xxxxmodule to use PyModule_AddType. Mar 24, 2020
@corona10 corona10 changed the title [WIP] bpo-40024: Update xxxxmodule to use PyModule_AddType. bpo-40024: Update xxxxmodule to use PyModule_AddType. Mar 24, 2020
@corona10 corona10 requested a review from pganssle March 24, 2020 03:56
@corona10
Copy link
Member Author

@vstinner @pganssle Please take a look :)

vstinner
vstinner reviewed Mar 24, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weakref_exec() of Modules/_weakref.c would also benefit of PyModule_AddType().

@corona10
Copy link
Member Author

@vstinner Updated! Please take a look.

@corona10 corona10 requested a review from vstinner March 24, 2020 18:43
@vstinner vstinner mentioned this pull request Mar 24, 2020
Closed
@corona10
Copy link
Member Author

@vstinner Updated!

@vstinner vstinner merged commit 37fcbb6 into python:master Mar 24, 2020
@vstinner
Copy link
Member

Thanks @corona10, I merged your PR.

@corona10 corona10 deleted the bpo-40024-part2 branch March 28, 2020 15:50
@aeros aeros mentioned this pull request Apr 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaqq dimaqq dimaqq approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@abalkin abalkin Awaiting requested review from abalkin

@asvetlov asvetlov Awaiting requested review from asvetlov

@rhettinger rhettinger Awaiting requested review from rhettinger

@tiran tiran Awaiting requested review from tiran

@pganssle pganssle Awaiting requested review from pganssle

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@corona10 @vstinner @dimaqq @pganssle @the-knights-who-say-ni @bedevere-bot