Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39879: Update docs dict preserve insertion order #19006

Merged
merged 23 commits into from
Mar 26, 2020
Merged

bpo-39879: Update docs dict preserve insertion order #19006

merged 23 commits into from
Mar 26, 2020

Conversation

AkechiShiro
Copy link
Contributor

@AkechiShiro AkechiShiro commented Mar 15, 2020 •
edited
Loading

  • Added in language reference that dict are now insertion-ordered since Python version 3.7
    - Behavior of dict are now the same as the behavior of collections.OrderedDict

https://bugs.python.org/issue39879

Lahfa Samy added 2 commits March 15, 2020 01:51
bpo-39879: Update docs dict preserve insertion order
38eb8cd 
* Added in language reference that dict are now insertion-ordered since
	Python version 3.7
* Behavior of dict are now the same as the behavior of
	collections.OrderedDict
Fixed a typo
fb8e1ca
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@AkechiShiro

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 15, 2020
zware
zware requested changes Mar 17, 2020
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also my comment on the issue.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Lahfa Samy added 4 commits March 18, 2020 01:50
Applying requested changes
07808ec 
* Fixed lines wrapping at 80 characters following devguide.
* Removed unnecessary links.
* Removed mention about OrderedDict.
* Specified what is insertion order and how it works.
Merge branch 'docs-dict-ordered' of github.com:AkechiShiro/cpython in…
b9a536e 
…to docs-dict-ordered
Converting tabs to space
d9458c3
Fix trailing whitespace/convert tabs to space
659094d
@AkechiShiro
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@zware: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from zware March 18, 2020 01:34
@AkechiShiro
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@pfmoore, @zware: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from pfmoore March 25, 2020 19:04
@zware zware merged commit 59c644e into python:master Mar 26, 2020
@miss-islington
Copy link
Contributor

Thanks @AkechiShiro for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @AkechiShiro for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 26, 2020
@AkechiShiro @miss-islington
bpo-39879: Update datamodel docs to include dict ordering (pythonGH-1…
6adda26 
…9006)

Co-authored-by: furkanonder <furkantahaonder@gmail.com>
(cherry picked from commit 59c644e)

Co-authored-by: Lahfa Samy <lahfa121999@gmail.com>
@bedevere-bot
Copy link

GH-19173 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 26, 2020
@AkechiShiro @miss-islington
bpo-39879: Update datamodel docs to include dict ordering (pythonGH-1…
ff9a379 
…9006)

Co-authored-by: furkanonder <furkantahaonder@gmail.com>
(cherry picked from commit 59c644e)

Co-authored-by: Lahfa Samy <lahfa121999@gmail.com>
@bedevere-bot
Copy link

GH-19174 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Mar 26, 2020
@miss-islington @AkechiShiro
bpo-39879: Update datamodel docs to include dict ordering (GH-19006)
ea0eeb8 
Co-authored-by: furkanonder <furkantahaonder@gmail.com>
(cherry picked from commit 59c644e)

Co-authored-by: Lahfa Samy <lahfa121999@gmail.com>
miss-islington added a commit that referenced this pull request Mar 26, 2020
@miss-islington @AkechiShiro
bpo-39879: Update datamodel docs to include dict ordering (GH-19006)
96686c7 
Co-authored-by: furkanonder <furkantahaonder@gmail.com>
(cherry picked from commit 59c644e)

Co-authored-by: Lahfa Samy <lahfa121999@gmail.com>
@furkanonder furkanonder mentioned this pull request Mar 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfmoore pfmoore pfmoore approved these changes

@zware zware zware approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AkechiShiro @the-knights-who-say-ni @bedevere-bot @miss-islington @pfmoore @zware @furkanonder