Skip to content

bpo-39705 : sorted() tutorial example under looping techniques improved #18999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 18, 2020
Merged

bpo-39705 : sorted() tutorial example under looping techniques improved #18999

merged 10 commits into from
May 18, 2020

Conversation

kumiDa
Copy link
Contributor

@kumiDa kumiDa commented Mar 14, 2020

  • The previous example for the sorted() functionality with set() is given an explanation that set() will eliminate duplicates.
  • Additional example just showing the basic functionality of sorted() is included.

https://bugs.python.org/issue39705

kumiDa and others added 9 commits March 11, 2020 23:17
In the whatsnew section, under the point which mentions the deprecation of getchildren() and getiterator()
through bpo-36543, it is suggested to use iter() instead.

Ideally there should be a suggestion to use Element.iter() instead.

The commits does the above modification.
In the whatsnew section, under the point which mentions the deprecation of getchildren() and getiterator()
through bpo-36543, it is suggested to use iter() instead.

Ideally there should be a suggestion to use Element.iter() instead.

The commits does the above modification.
* The previous example for the sorted() functionality with set() is given a suggestive explanation.
* Additional example just showing the basic functionality of sorted() is included.
Copy link
Contributor

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kumiDa
Copy link
Contributor Author

kumiDa commented Mar 15, 2020

Thank you for the review @epicfaace!
@rhettinger, can you also please review this PR and suggest me if there is anything missing in this particular change to the documentation.

@rhettinger rhettinger merged commit eefd4e0 into python:master May 18, 2020
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants