Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39937: modify iter() suggestion to Element.iter() #18937

Merged
merged 6 commits into from
Mar 14, 2020
Merged

bpo-39937: modify iter() suggestion to Element.iter() #18937

merged 6 commits into from
Mar 14, 2020

Conversation

kumiDa
Copy link
Contributor

@kumiDa kumiDa commented Mar 11, 2020

In the whatsnew section, under the point which mentions the deprecation of getchildren() and getiterator()
through bpo-36543, it is suggested to use iter() instead.

Ideally there should be a suggestion to use Element.iter() instead.

The commits does the above modification.

https://bugs.python.org/issue39937

In the whatsnew section, under the point which mentions the deprecation of getchildren() and getiterator()
through bpo-36543, it is suggested to use iter() instead.

Ideally there should be a suggestion to use Element.iter() instead.

The commits does the above modification.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@rahul-kumi

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 11, 2020
@kumiDa kumiDa changed the title modify iter() suggestion to Element.iter() bpo39937: modify iter() suggestion to Element.iter() Mar 11, 2020
@kumiDa kumiDa changed the title bpo39937: modify iter() suggestion to Element.iter() bpo-39937: modify iter() suggestion to Element.iter() Mar 11, 2020
blurb-it bot and others added 3 commits March 11, 2020 18:08
In the whatsnew section, under the point which mentions the deprecation of getchildren() and getiterator()
through bpo-36543, it is suggested to use iter() instead.

Ideally there should be a suggestion to use Element.iter() instead.

The commits does the above modification.
@tirkarthi
Copy link
Member

NEWS entry is not needed. Please remove it.

Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@tirkarthi
Copy link
Member

@serhiy-storchaka It will be helpful to have your review in this since it caused some confusion over builtin function iter to be used at biopython/biopython#2774 (comment)

@tirkarthi
Copy link
Member

This change is for 3.9 in whatsnew. I think backport to 3.8 is not needed.

@tirkarthi
Copy link
Member

Thanks @serhiy-storchaka for the review. Congratulations @rahul-kumi on your first patch :)

@kumiDa
Copy link
Contributor Author

kumiDa commented Mar 14, 2020

Thanks @serhiy-storchaka for the review. Congratulations @rahul-kumi on your first patch :)

Thank you @tirkarthi and @serhiy-storchaka !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants