-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-39937: modify iter() suggestion to Element.iter() #18937
Conversation
In the whatsnew section, under the point which mentions the deprecation of getchildren() and getiterator() through bpo-36543, it is suggested to use iter() instead. Ideally there should be a suggestion to use Element.iter() instead. The commits does the above modification.
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: @rahul-kumi For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
In the whatsnew section, under the point which mentions the deprecation of getchildren() and getiterator() through bpo-36543, it is suggested to use iter() instead. Ideally there should be a suggestion to use Element.iter() instead. The commits does the above modification.
NEWS entry is not needed. Please remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
@serhiy-storchaka It will be helpful to have your review in this since it caused some confusion over builtin function |
This change is for 3.9 in whatsnew. I think backport to 3.8 is not needed. |
Thanks @serhiy-storchaka for the review. Congratulations @rahul-kumi on your first patch :) |
Thank you @tirkarthi and @serhiy-storchaka ! |
In the whatsnew section, under the point which mentions the deprecation of getchildren() and getiterator()
through bpo-36543, it is suggested to use iter() instead.
Ideally there should be a suggestion to use Element.iter() instead.
The commits does the above modification.
https://bugs.python.org/issue39937