gh-76785: Multiple Interpreters in the Stdlib (PEP 554) #18817

nanjekyejoannah · 2020-03-06T22:06:42Z

This is the initial implementation of the high-level part of PEP 554.

I have added some changes from #17323 by @LewisGaul to aid have the ability to List interpreters associated with a channel end.

Co-author : Lewis Gaul.

cc @ericsnowcurrently @vstinner

https://bugs.python.org/issue39881

Issue: [subinterpreters] PEP 554 implementation: add interpreters module #76785

Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>

aeros

Thanks for working on this @nanjekyejoannah! As someone who hasn't extensively worked with subinterpreters (mainly since it was only available through the C-API), I greatly look forward to exploring their various use cases and experimenting with them as model of concurrency. :)

I have some general suggestions regarding the documentation; I'll try to add some additional ones as I find the time.

Doc/library/interpreters.rst

aeros · 2020-03-08T02:21:48Z

Doc/library/interpreters.rst

+    .. method:: is_running()
+
+       Return whether or not the identified interpreter is running.
+       It returns `True` and `False` otherwise.


IMO, this could be better phrased as:

Return `True` if the identified interpreter is running.

For comparison, see https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.loop.is_running or https://docs.python.org/3/library/concurrent.futures.html#concurrent.futures.Future.cancelled.

aeros · 2020-03-08T02:23:46Z

Doc/library/interpreters.rst

+    .. method:: destroy()
+
+       Destroy the interpreter. Attempting to destroy the current
+       interpreter results in a `RuntimeError`.


IIRC, it also results in a RuntimeError if an interpreter is attempted to be destroyed which is presently running (from my recollection of the C-API function, interp_destroy()). Could this also be mentioned?

aeros · 2020-03-08T02:28:22Z

Doc/library/interpreters.rst

+    .. method:: release()
+
+        Release the channel for the current interpreter.
+        By default both ends are released. Releasing an already
+        released end results in a ``ChannelReleasedError`` exception.


IMO, the second sentence could be better phrased as:

Releasing an end more than once results in a :exc:`ChannelReleasedError`.

(Also added a Sphinx role, which should generate an inline link to the exception definition below)

aeros · 2020-03-08T03:05:57Z

Doc/library/interpreters.rst

+    .. method:: send_buffer_nowait(obj)
+
+       Like ``send_buffer()`` but return ``False`` if not received.


See my above comment on send_nowait().

Doc/library/interpreters.rst

aeros · 2020-03-08T03:06:45Z

Doc/library/interpreters.rst

+
+        Close the channel in all interpreters. By default
+        both ends are closed. closing an already closed end
+        results in a ``ChannelClosedError`` exception.


Suggested change

results in a ``ChannelClosedError`` exception.

results in a :exc:`ChannelClosedError`.

aeros · 2020-03-08T03:10:18Z

Doc/library/interpreters.rst

+.. function:: list_all_channels()
+
+   Return all open channels.


Does this return a list of Channel objects or something else? I think it would be helpful to mention that here.

aeros · 2020-03-08T03:11:16Z

Doc/library/interpreters.rst

+.. function:: create()
+
+   Initialize a new (idle) Python interpreter. Get the currently
+   running interpreter. This method returns an ``Interpreter`` object.


Was "Get the currently running interpreter" accidentally included here?

Co-authored-by: Kyle Stanley <aeros167@gmail.com>

vstinner · 2020-05-15T01:21:27Z

I marked bpo-39881 as a duplicate of bpo-32604. I changed this PR title to use bpo-32604.

erlend-aasland · 2024-01-12T12:05:59Z

This PR should be retargeted to PEP-734.

nanjekyejoannah and others added 17 commits September 10, 2019 11:00

Add tests for the interpreters module

f5b464a

create stdlib interpreters module and _interpreters internal module

331be62

Global initial Sub-Interpreters functions

3f2f2f4

update __all__

4618343

Implementation of all methods and relevant documentation

ec63183

Update Lib/test/test_interpreters.py

80f6808

Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>

Update Lib/test/test_interpreters.py

724e618

Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>

Update Lib/test/test_interpreters.py

abd0011

Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>

Update Lib/test/test_interpreters.py

d502415

Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>

Update Doc/library/interpreters.rst

a751e15

Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>

Update Doc/library/interpreters.rst

56083c2

Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>

Update Doc/library/interpreters.rst

14e97fc

Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>

Add tests

9ab54eb

Fix tests

b7dce73

Add send buffer functionality

e9b56b8

Add tests for Global functions and Interpreter

2bf89d4

Test coverage and documentation

158e54f

nanjekyejoannah requested a review from ericsnowcurrently March 6, 2020 22:06

nanjekyejoannah requested a review from a team as a code owner March 6, 2020 22:06

the-knights-who-say-ni added the CLA signed label Mar 6, 2020

bedevere-bot added the awaiting core review label Mar 6, 2020

blurb-it bot and others added 2 commits March 6, 2020 22:09

📜🤖 Added by blurb_it.

9e2f9d6

Fix Merge conflict

2e608fb

aeros reviewed Mar 8, 2020

View reviewed changes

aeros added the type-feature A feature request or enhancement label Mar 8, 2020

nanjekyejoannah mentioned this pull request Apr 25, 2020

bpo-38880: List interpreters associated with a channel end #17323

Merged

nanjekyejoannah and others added 2 commits May 7, 2020 18:01

Update Doc/library/interpreters.rst

71ad4d7

Co-authored-by: Kyle Stanley <aeros167@gmail.com>

Update Doc/library/interpreters.rst

b12e3d2

Co-authored-by: Kyle Stanley <aeros167@gmail.com>

vstinner changed the title ~~bpo-39881: Multiple Interpreters in the Stdlib (PEP 554)~~ bpo-32604: Multiple Interpreters in the Stdlib (PEP 554) May 15, 2020

ericsnowcurrently mentioned this pull request Apr 10, 2022

[subinterpreters] PEP 554 implementation: add interpreters module #76785

Open

ezio-melotti removed the CLA signed label Jul 13, 2022

erlend-aasland changed the title ~~bpo-32604: Multiple Interpreters in the Stdlib (PEP 554)~~ gh-76785: Multiple Interpreters in the Stdlib (PEP 554) Jan 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-76785: Multiple Interpreters in the Stdlib (PEP 554) #18817

gh-76785: Multiple Interpreters in the Stdlib (PEP 554) #18817

nanjekyejoannah commented Mar 6, 2020 •

edited by bedevere-app bot

Loading

aeros left a comment

aeros Mar 8, 2020

aeros Mar 8, 2020 •

edited

Loading

aeros Mar 8, 2020

aeros Mar 8, 2020

aeros Mar 8, 2020

aeros Mar 8, 2020 •

edited

Loading

aeros Mar 8, 2020

vstinner commented May 15, 2020 •

edited by bedevere-bot

Loading

erlend-aasland commented Jan 12, 2024

		.. method:: send_buffer_nowait(obj)

		Like ``send_buffer()`` but return ``False`` if not received.

	results in a ``ChannelClosedError`` exception.
	results in a :exc:`ChannelClosedError`.

gh-76785: Multiple Interpreters in the Stdlib (PEP 554) #18817

Are you sure you want to change the base?

gh-76785: Multiple Interpreters in the Stdlib (PEP 554) #18817

Conversation

nanjekyejoannah commented Mar 6, 2020 • edited by bedevere-app bot Loading

aeros left a comment

Choose a reason for hiding this comment

aeros Mar 8, 2020

Choose a reason for hiding this comment

aeros Mar 8, 2020 • edited Loading

Choose a reason for hiding this comment

aeros Mar 8, 2020

Choose a reason for hiding this comment

aeros Mar 8, 2020

Choose a reason for hiding this comment

aeros Mar 8, 2020

Choose a reason for hiding this comment

aeros Mar 8, 2020 • edited Loading

Choose a reason for hiding this comment

aeros Mar 8, 2020

Choose a reason for hiding this comment

vstinner commented May 15, 2020 • edited by bedevere-bot Loading

erlend-aasland commented Jan 12, 2024

nanjekyejoannah commented Mar 6, 2020 •

edited by bedevere-app bot

Loading

aeros Mar 8, 2020 •

edited

Loading

aeros Mar 8, 2020 •

edited

Loading

vstinner commented May 15, 2020 •

edited by bedevere-bot

Loading