Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39702: Update the Language Reference (PEP 614). #18802

Merged
merged 4 commits into from
Mar 7, 2020

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Mar 6, 2020

This should be it for PEP 614.

https://bugs.python.org/issue39702

@@ -550,6 +550,10 @@ is roughly equivalent to ::

except that the original function is not temporarily bound to the name ``func``.

.. versionchanged:: 3.9
Functions may be decorated with any valid expression. Previously, the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "... with any valid assignment expression". Ditto for the two other sentences you added.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be jumping back and forth between these two PRs.

I've changed the two notes in the Language Reference, since the linked assignment_expression nodes are well-defined in that context.

I'm resistant to changing the What's New wording, since the phrase "assignment expression" has a different meaning here... the walrus is just about the last thing that I want readers of this document to associate with the grammar change.

Using "expression" keeps with the wording in the PEP, which defines the term well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I will merge things tomorrow.

@gvanrossum gvanrossum merged commit 8f13053 into python:master Mar 7, 2020
@brandtbucher brandtbucher deleted the 614-docs branch July 21, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants