bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 #18678

erlend-aasland · 2020-02-27T14:59:47Z

https://bugs.python.org/issue38380

Automerge-Triggered-By: @zooba

codecov · 2020-02-27T15:30:45Z

Codecov Report

Merging #18678 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #18678     +/-   ##
=========================================
  Coverage   82.12%   82.13%             
=========================================
  Files        1956     1955      -1     
  Lines      589830   584773   -5057     
  Branches    44477    44489     +12     
=========================================
- Hits       484427   480326   -4101     
+ Misses      95752    94800    -952     
+ Partials     9651     9647      -4

Impacted Files	Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py	`30.00% <0.00%> (-65.00%)`	⬇️
Lib/distutils/command/bdist_rpm.py	`7.63% <0.00%> (-56.88%)`	⬇️
Modules/_decimal/libmpdec/umodarith.h	`80.76% <0.00%> (-19.24%)`	⬇️
Lib/test/test_urllib2net.py	`76.92% <0.00%> (-13.85%)`	⬇️
Lib/test/test_smtpnet.py	`78.57% <0.00%> (-7.15%)`	⬇️
Lib/ftplib.py	`63.85% <0.00%> (-6.06%)`	⬇️
Lib/test/test_ftplib.py	`87.11% <0.00%> (-4.72%)`	⬇️
Tools/scripts/db2pickle.py	`17.82% <0.00%> (-3.97%)`	⬇️
Tools/scripts/pickle2db.py	`16.98% <0.00%> (-3.78%)`	⬇️
Lib/test/test_socket.py	`71.94% <0.00%> (-3.77%)`	⬇️
... and 350 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a4d57...6a89f64. Read the comment docs.

erlend-aasland · 2020-02-27T18:28:50Z

FYI: The Windows build fails because I forgot to git tag the upgrade with sqlite-3.30.1.0 in python/cpython-source-deps#17. I've notified the maintainers, hoping that one of them can tag it for me, since I lack the permissions to do so (and creating a PR for just one tag is not possible, AFAIK.)

erlend-aasland · 2020-02-29T05:36:03Z

FYI, updated to most recent SQLite3 version. See bug tracker for discussion.

Misc/NEWS.d/next/Build/2020-02-28-23-51-27.bpo-38380.TpOBCj.rst

Misc/NEWS.d/next/Build/2020-02-28-23-51-47.bpo-38380.u-ySyA.rst

miss-islington · 2020-03-02T11:56:27Z

@erlend-aasland: Status check is done, and it's a success ✅ .

miss-islington · 2020-03-02T11:56:29Z

Sorry, I can't merge this PR. Reason: Required status check "Azure Pipelines PR" is expected..

zooba · 2020-03-02T12:05:48Z

Closing/reopening to retrigger Azure Pipelines

miss-islington · 2020-03-02T12:05:59Z

@erlend-aasland: Status check is done, and it's a success ✅ .

miss-islington · 2020-03-02T12:06:00Z

@erlend-aasland: Status check is done, and it's a success ✅ .

miss-islington · 2020-03-02T12:06:01Z

Sorry, I can't merge this PR. Reason: Required status check "Azure Pipelines PR" is expected..

miss-islington · 2020-03-02T12:06:02Z

Sorry, I can't merge this PR. Reason: Required status check "Azure Pipelines PR" is expected..

miss-islington · 2020-03-02T12:25:09Z

@erlend-aasland: Status check is done, and it's a success ✅ .

miss-islington · 2020-03-02T12:25:14Z

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@zooba

…18678) Automerge-Triggered-By: @zooba (cherry picked from commit 1382c32) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot · 2020-03-02T12:25:28Z

GH-18740 is a backport of this pull request to the 3.8 branch.

@zooba

…18678) Automerge-Triggered-By: @zooba (cherry picked from commit 1382c32) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

bedevere-bot · 2020-03-02T12:25:35Z

GH-18741 is a backport of this pull request to the 3.7 branch.

@zooba

Automerge-Triggered-By: @zooba (cherry picked from commit 1382c32) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

@zooba

Automerge-Triggered-By: @zooba (cherry picked from commit 1382c32) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

erlend-aasland requested review from a team as code owners February 27, 2020 14:59

the-knights-who-say-ni added the CLA signed label Feb 27, 2020

Erlend E. Aasland added 2 commits February 28, 2020 23:54

bpo-38380: Update macOS builds to use SQLite 3.31.1

b9ff44b

bpo-38380: Update Windows builds to use SQLite 3.31.1

4a151cd

erlend-aasland force-pushed the fix-issue-38380 branch from 28e78d3 to 4a151cd Compare February 29, 2020 05:35

erlend-aasland changed the title ~~bpo-38380: Update macOS & Windows builds to SQLite v3.30.1~~ bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 Feb 29, 2020

zooba reviewed Mar 2, 2020

View reviewed changes

Misc/NEWS.d/next/Build/2020-02-28-23-51-27.bpo-38380.TpOBCj.rst Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Build/2020-02-28-23-51-47.bpo-38380.u-ySyA.rst Outdated Show resolved Hide resolved

zooba added needs backport to 3.7 labels Mar 2, 2020

Move NEWS blurbs from Build/* to Windows/ and macOS/

6a89f64

zooba approved these changes Mar 2, 2020

View reviewed changes

bedevere-bot added the awaiting merge label Mar 2, 2020

zooba added the 🤖 automerge label Mar 2, 2020

zooba closed this Mar 2, 2020

zooba reopened this Mar 2, 2020

miss-islington merged commit 1382c32 into python:master Mar 2, 2020

bedevere-bot removed the awaiting merge label Mar 2, 2020

bedevere-bot removed the needs backport to 3.8 label Mar 2, 2020

bedevere-bot removed the needs backport to 3.7 label Mar 2, 2020

erlend-aasland deleted the fix-issue-38380 branch March 2, 2020 12:27

miss-islington added a commit that referenced this pull request Mar 2, 2020

bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 (GH-18678)

7ad9982

Automerge-Triggered-By: @zooba (cherry picked from commit 1382c32) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

miss-islington added a commit that referenced this pull request Mar 2, 2020

bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 (GH-18678)

7ca251b

Automerge-Triggered-By: @zooba (cherry picked from commit 1382c32) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 #18678

bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 #18678

erlend-aasland commented Feb 27, 2020 •

edited by miss-islington

Loading

codecov bot commented Feb 27, 2020 •

edited

Loading

erlend-aasland commented Feb 27, 2020

erlend-aasland commented Feb 29, 2020

miss-islington commented Mar 2, 2020

miss-islington commented Mar 2, 2020

zooba commented Mar 2, 2020

miss-islington commented Mar 2, 2020

miss-islington commented Mar 2, 2020

miss-islington commented Mar 2, 2020

miss-islington commented Mar 2, 2020

miss-islington commented Mar 2, 2020

miss-islington commented Mar 2, 2020

bedevere-bot commented Mar 2, 2020

bedevere-bot commented Mar 2, 2020

bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 #18678

bpo-38380: Update macOS & Windows builds to SQLite v3.31.1 #18678

Conversation

erlend-aasland commented Feb 27, 2020 • edited by miss-islington Loading

codecov bot commented Feb 27, 2020 • edited Loading

Codecov Report

erlend-aasland commented Feb 27, 2020

erlend-aasland commented Feb 29, 2020

miss-islington commented Mar 2, 2020

miss-islington commented Mar 2, 2020

zooba commented Mar 2, 2020

miss-islington commented Mar 2, 2020

miss-islington commented Mar 2, 2020

miss-islington commented Mar 2, 2020

miss-islington commented Mar 2, 2020

miss-islington commented Mar 2, 2020

miss-islington commented Mar 2, 2020

bedevere-bot commented Mar 2, 2020

bedevere-bot commented Mar 2, 2020

erlend-aasland commented Feb 27, 2020 •

edited by miss-islington

Loading

codecov bot commented Feb 27, 2020 •

edited

Loading