bpo-30566: Fix IndexError when using punycode codec #18632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to decode an invalid string with the punycode codec shoud raise UnicodeError.
Codecov Report
@@ Coverage Diff @@
## master #18632 +/- ##
==========================================
- Coverage 82.11% 82.07% -0.05%
==========================================
Files 1956 1955 -1
Lines 589456 584120 -5336
Branches 44459 44461 +2
==========================================
- Hits 484060 479400 -4660
+ Misses 95744 95098 -646
+ Partials 9652 9622 -30
Continue to review full report at Codecov.
|
|
Thanks @berkerpeksag for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
GH-18651 is a backport of this pull request to the 3.8 branch. |
|
GH-18652 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 25, 2020
Trying to decode an invalid string with the punycode codec shoud raise UnicodeError. (cherry picked from commit ba22e8f) Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
berkerpeksag
added a commit
that referenced
this pull request
Feb 25, 2020
berkerpeksag
added a commit
that referenced
this pull request
Feb 25, 2020
farazs-github
pushed a commit
to MediaTek-Labs/cpython
that referenced
this pull request
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to decode an invalid string with the punycode codec
shoud raise UnicodeError.
https://bugs.python.org/issue30566