Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39638: Keep ASDL signatures in the AST nodes #18515

Merged
merged 7 commits into from
Mar 16, 2020
Merged

bpo-39638: Keep ASDL signatures in the AST nodes #18515

merged 7 commits into from
Mar 16, 2020

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented Feb 15, 2020 •
edited by bedevere-bot
Loading

@isidentical isidentical force-pushed the bpo-39638 branch 3 times, most recently from 83dffaf to 716f2e3 Compare February 15, 2020 20:10
@isidentical isidentical marked this pull request as ready for review February 22, 2020 16:26
@serhiy-storchaka serhiy-storchaka self-requested a review March 14, 2020 11:24
@serhiy-storchaka
Copy link
Member

Please resolve conflicts and update tests.

1 similar comment
@serhiy-storchaka
Copy link
Member

Please resolve conflicts and update tests.

@isidentical isidentical force-pushed the bpo-39638 branch 2 times, most recently from 29d3cd5 to ace16c9 Compare March 14, 2020 11:50
@isidentical
Copy link
Member Author

Thanks for the ping, I updated the tests and rebased this PR to master. @serhiy-storchaka

serhiy-storchaka
serhiy-storchaka reviewed Mar 14, 2020
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice! Added several suggestions.

serhiy-storchaka
serhiy-storchaka reviewed Mar 14, 2020
View reviewed changes
@isidentical isidentical force-pushed the bpo-39638 branch 2 times, most recently from aafde35 to 90535cf Compare March 14, 2020 18:36
serhiy-storchaka
serhiy-storchaka reviewed Mar 14, 2020
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Mar 15, 2020
View reviewed changes
serhiy-storchaka
serhiy-storchaka approved these changes Mar 15, 2020
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@serhiy-storchaka
Copy link
Member

Please regenerate Python-ast.c.

isidentical and others added 4 commits March 16, 2020 03:35
@isidentical
use old style formattings
a54f837
@isidentical @serhiy-storchaka
break the line before docstrings.
6968229 
Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com>
@isidentical @serhiy-storchaka
simplify the code
d074dc2 
Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com>
@isidentical
keep diff minimal
63bdbe7
@isidentical
Copy link
Member Author

@serhiy-storchaka done

@serhiy-storchaka serhiy-storchaka merged commit 4ab362c into python:master Mar 16, 2020
@serhiy-storchaka
Copy link
Member

Nice idea, great PR!

colesbury referenced this pull request in colesbury/nogil Oct 6, 2021
@isidentical @colesbury
bpo-39638: Keep ASDL signatures in the AST nodes (GH-18515)
8808eb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isidentical @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot