-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-39573: Add Py_IS_TYPE macro #18488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to modify Argument Clinic in a separated PR, but use this PR to update PyXXX_CheckExact() macros. See: nascheme@c156300
You should credit Neil if you reuse his commit: add Author: Neil Schemenauer <nas-github@arctrix.com>
at the end of your commit message.
Codecov Report
@@ Coverage Diff @@
## master #18488 +/- ##
===========================================
+ Coverage 82.11% 83.19% +1.08%
===========================================
Files 1956 1571 -385
Lines 589145 414668 -174477
Branches 44447 44450 +3
===========================================
- Hits 483801 345002 -138799
+ Misses 95697 60016 -35681
- Partials 9647 9650 +3
Continue to review full report at Codecov.
|
Co-Author: Neil Schemenauer <nas-github@arctrix.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vstinner I've updated the PR :)
Misc/NEWS.d/next/Core and Builtins/2020-02-13-01-30-22.bpo-39573.uTFj1m.rst
Outdated
Show resolved
Hide resolved
@vstinner Updated! Thanks for the review |
Misc/NEWS.d/next/Core and Builtins/2020-02-13-01-30-22.bpo-39573.uTFj1m.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Core and Builtins/2020-02-13-01-30-22.bpo-39573.uTFj1m.rst
Outdated
Show resolved
Hide resolved
Equivalent to: Py_TYPE(o) == type. | ||
|
||
.. versionadded:: 3.9 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops, I noticed a typo in one of my previous commit. Would you mind to take this PR as an opportunity to fix it?
https://docs.python.org/dev/c-api/structures.html#c.Py_SET_SIZE
"Set the object o size of size." => "Set ... to size."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sure :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, @brandtbucher wrote PR #18496. I will ask him to fix the typo there. You can ignore this special request ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vstinner Updated :) |
Thanks, merged. You can now redo your Argument Clinic change on top of it. |
https://bugs.python.org/issue39573