Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39011: Preserve line endings within ElementTree attributes #18468

Merged
merged 2 commits into from
Apr 12, 2020
Merged

bpo-39011: Preserve line endings within ElementTree attributes #18468

merged 2 commits into from
Apr 12, 2020

Conversation

mefistotelis
Copy link
Contributor

@mefistotelis mefistotelis commented Feb 12, 2020 •
edited by bedevere-bot
Loading

@mefistotelis
bpo-39011: Preserve line endings within attributes
66c2859 
Line endings within attributes were previously normalized to "\n".
This patch removes that normalization, as line endings which were
replaced by entity numbers should be preserved in original form.
@mefistotelis
bpo-39011: White space preservation in attribs, test and news
4afc662 
This updates tests for the changes in white space handling.
Also ads entry to NEWS and whatsnew.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@mefistotelis

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #18468 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18468      +/-   ##
==========================================
- Coverage   82.12%   82.11%   -0.01%     
==========================================
  Files        1955     1954       -1     
  Lines      588958   583611    -5347     
  Branches    44428    44427       -1     
==========================================
- Hits       483663   479257    -4406     
+ Misses      95652    94708     -944     
- Partials     9643     9646       +3
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 325 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b138dd2...4afc662. Read the comment docs.

@scoder scoder merged commit 5fd8123 into python:master Apr 12, 2020
@scoder
Copy link
Contributor

scoder commented Apr 12, 2020

Thanks @mefistotelis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mefistotelis @the-knights-who-say-ni @scoder @bedevere-bot