Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-11822: Improve disassembly to show embedded code objects (limited depth). #1844

Merged

Conversation

serhiy-storchaka
Copy link
Member

This is an alternate patch for bpo-11822. The depth of recursion is limited by the parameter depth.

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label May 28, 2017
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the discussion at https://bugs.python.org/issue11822#msg291780, if we go with this approach, the default should be None (to render the entire code tree), rather than 0.

@ncoghlan
Copy link
Contributor

The Appveyor failure doesn't look related - it's an issue with accessing a UNC path in the import tests.

@serhiy-storchaka serhiy-storchaka merged commit 1efbf92 into python:master Jun 11, 2017
@serhiy-storchaka serhiy-storchaka deleted the dis-recursive-limited branch June 11, 2017 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants