Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39582: ossaudiodev module update helpers signature for ioctl calls. #18412

Merged
merged 1 commit into from
Mar 14, 2020
Merged

bpo-39582: ossaudiodev module update helpers signature for ioctl calls. #18412

merged 1 commit into from
Mar 14, 2020

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Feb 8, 2020 •
edited by bedevere-bot
Loading

@devnexen devnexen changed the title ossaudiodev module update helpers signature for ioctl calls. bpo-39582: ossaudiodev module update helpers signature for ioctl calls. Feb 8, 2020
@devnexen
Copy link
Contributor Author

devnexen commented Feb 8, 2020

no news.

@codecov
Copy link

codecov bot commented Feb 8, 2020

Codecov Report

Merging #18412 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18412   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files        1954     1954           
  Lines      583588   583588           
  Branches    44428    44428           
=======================================
+ Hits       479240   479242    +2     
+ Misses      94701    94699    -2     
  Partials     9647     9647
Impacted Files Coverage Δ
Lib/idlelib/colorizer.py 85.78% <0.00%> (-1.02%) ⬇️
Modules/_xxtestfuzz/fuzzer.c 73.36% <0.00%> (-1.01%) ⬇️
Modules/cjkcodecs/multibytecodec.c 72.72% <0.00%> (-0.48%) ⬇️
Lib/test/test_asyncore.py 93.62% <0.00%> (-0.18%) ⬇️
Objects/listobject.c 90.92% <0.00%> (ø) ⬆️
Lib/idlelib/squeezer.py 93.23% <0.00%> (ø) ⬆️
Programs/_testembed.c 89.55% <0.00%> (+0.12%) ⬆️
Modules/_io/bufferedio.c 90.40% <0.00%> (+0.29%) ⬆️
Lib/idlelib/editor.py 51.09% <0.00%> (+0.35%) ⬆️
Lib/idlelib/scrolledlist.py 36.60% <0.00%> (+0.89%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0edc2c7...a527c6c. Read the comment docs.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.7 type-bug An unexpected behavior, bug, or error skip news labels Mar 14, 2020
@serhiy-storchaka serhiy-storchaka merged commit b81f40f into python:master Mar 14, 2020
@miss-islington
Copy link
Contributor

Thanks @devnexen for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 14, 2020
@devnexen @miss-islington
bpo-39582: ossaudiodev module update helpers signature for ioctl call…
1d4944d 
…s. (pythonGH-18412)

(cherry picked from commit b81f40f)

Co-authored-by: David CARLIER <devnexen@gmail.com>
@bedevere-bot
Copy link

GH-18991 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-18992 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 14, 2020
@devnexen @miss-islington
bpo-39582: ossaudiodev module update helpers signature for ioctl call…
c966ef2 
…s. (pythonGH-18412)

(cherry picked from commit b81f40f)

Co-authored-by: David CARLIER <devnexen@gmail.com>
miss-islington added a commit that referenced this pull request Mar 14, 2020
@miss-islington @devnexen
bpo-39582: ossaudiodev module update helpers signature for ioctl call…
148786a 
…s. (GH-18412)

(cherry picked from commit b81f40f)

Co-authored-by: David CARLIER <devnexen@gmail.com>
miss-islington added a commit that referenced this pull request Mar 14, 2020
@miss-islington @devnexen
bpo-39582: ossaudiodev module update helpers signature for ioctl call…
9644702 
…s. (GH-18412)

(cherry picked from commit b81f40f)

Co-authored-by: David CARLIER <devnexen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devnexen @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni