-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve grammar in the import system reference documentation #18209
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Doc/reference/import.rst
Outdated
@@ -857,7 +857,7 @@ module. ``find_spec()`` returns a fully populated spec for the module. | |||
This spec will always have "loader" set (with one exception). | |||
|
|||
To indicate to the import machinery that the spec represents a namespace | |||
:term:`portion`. the path entry finder sets "loader" on the spec to | |||
:term:`portion` the path entry finder sets "loader" on the spec to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a comma, not a space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your time @Bonifacio2, and welcome to CPython! 😎
I assume that you've seen the bot's message about the CLA?
Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
Yes, I saw it. I already created my b.p.o account, set the github account, signed the agreement, received my certificate, but https://check-python-cla.herokuapp.com/ still says I haven't signed the CLA. |
Okay, I'd give it a business day or two then before it's marked as received. It's my understanding that they're processed manually by a human at the PSF. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hello, @Mariatta . Should I open the backport PRs for the 3.7 and 3.8 branches now or should I wait for this to be merged? |
The bot will open them automatically. Your work here is done! |
@Mariatta - where can I find out what the |
@cjw296 The PR will be automatically merged by @miss-islington if all of the following are true:
Additionally, automerge takes care of replacing the "#NNNN" into "GH-NNNN" in the commit message. Through GitHub web UI, the only restriction it has is that you must have commit right, and that all checks pass. Core dev can use their own judgement and bypass the CLA check if they see fit. In the past, some of us would bypass CLA check if it is simple typo fixes. Personally for me though, I rather have CLA always signed, and let the bot do the merging. Hope this helps. |
perfect, thankyou! |
Thanks @Bonifacio2 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
GH-18268 is a backport of this pull request to the 3.8 branch. |
GH-18269 is a backport of this pull request to the 3.7 branch. |
Congrats on your first CPython contribution @Bonifacio2! 🍾 Looking forward to seeing more from you in the future. |
Replaced the period with a comma.
Automerge-Triggered-By: @Mariatta