Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Doc/README.txt to Doc/README.rst #18

Closed
wants to merge 7 commits into from
Closed

Rename Doc/README.txt to Doc/README.rst #18

wants to merge 7 commits into from
+4 −4

Conversation

ghost
Copy link

@ghost ghost commented Feb 11, 2017 •
edited by ghost
Loading

I have simply updated the document and its references to README.rst (thanks to whoever formatted it).

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:

  1. Sign the PSF contributor agreement
  2. Wait at least a day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  3. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@ghost ghost changed the title Rename README.txt to README.rst Rename Doc/README.txt to Doc/README.rst Feb 11, 2017
@ghost
Copy link
Author

ghost commented Feb 11, 2017

I have signed the CLA, so the PR will take a day for approval

@methane
Copy link
Member

methane commented Feb 11, 2017

@rogersachan master branch already renamed README.txt -> README.rst
Please rebase your branch.

@ghost
Copy link
Author

ghost commented Feb 11, 2017

I accidentally merged and destroyed this PR, so I'll close it now.

P.S. The extra option next to the merge button would have let you rebase it but ¯_(ツ)_/¯

@ghost ghost closed this Feb 11, 2017
@willingc
Copy link
Contributor

Hi @rogersachan,

Thanks for the PR. It's common practice in open source for the contributor to rebase their submission instead of the maintainer doing it. By the contributor doing the rebase, it makes things more efficient for multiple reviewers. 👍

paulmon added a commit to paulmon/cpython that referenced this pull request Jan 10, 2019
@paulmon
Merge pull request python#18 from paulmon/win-arm32-master-iot-readme
53244ed 
how to build for arm32
@pablogsal pablogsal mentioned this pull request Jun 12, 2020
Closed
@larryhastings larryhastings mentioned this pull request Jun 7, 2022
Closed
@itachaaa itachaaa mentioned this pull request Aug 22, 2022
Open
@mdboom mdboom mentioned this pull request Aug 25, 2022
Closed
@mdboom mdboom mentioned this pull request Nov 22, 2022
Closed
@ziegenbalg ziegenbalg mentioned this pull request Nov 30, 2022
Closed
nanjekyejoannah added a commit to nanjekyejoannah/cpython that referenced this pull request Feb 1, 2023
@bors @nanjekyejoannah
Merge python#18
ce2dc07 
18: Warn for encode and decode in base64 r=ltratt a=nanjekyejoannah

Add warnings for the base module.

**Notes:**

```
py2.x

>>> import base64
>>> from base64 import decodestring
>>> 

py3.x:

>>> import base64
>>> from base64 import decodestring
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name 'decodestring' 
from 'base64' (/usr/local/Cellar/python@3.9/3.9.12_1/
Frameworks/Python.framework/Versions/3.9/lib/python3.9/
base64.py)
```

Co-authored-by: Joannah Nanjekye <jnanjekye@python.org>
oraluben pushed a commit to oraluben/cpython that referenced this pull request Jun 25, 2023
@Fidget-Spinner @JuliaPoo
fix: off by one error in forward jump calculation (python#19)
f876fdb 
* fix: off by one error in forward jump calculation

* Test: fixed test for python#18

* test: remove broken test

---------

Co-authored-by: Jules <julia.poo.poo.poo@gmail.com>
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
Closed
@LinanV LinanV mentioned this pull request Oct 23, 2023
Closed
@stasos24 stasos24 mentioned this pull request Oct 24, 2023
Closed
@williamhu020 williamhu020 mentioned this pull request Nov 5, 2023
Closed
@kcatss kcatss mentioned this pull request Nov 15, 2023
Open
@kcatss kcatss mentioned this pull request Jan 14, 2024
Closed
@kcatss kcatss mentioned this pull request Feb 12, 2024
Closed
@kcatss kcatss mentioned this pull request Feb 20, 2024
Closed
@ngoldbaum ngoldbaum mentioned this pull request Sep 23, 2024
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@the-knights-who-say-ni @methane @willingc @superusercode