Skip to content

bpo-39273: Expose BUTTON5_* constants in the curses module if available #17996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 14, 2021
Merged

bpo-39273: Expose BUTTON5_* constants in the curses module if available #17996

merged 4 commits into from
Jan 14, 2021

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Jan 14, 2020 •
edited by bedevere-bot
Loading

@csabella csabella requested a review from Yhg1s May 28, 2020 22:56
lisroach
lisroach approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@lisroach lisroach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

serhiy-storchaka
serhiy-storchaka requested changes Oct 14, 2020
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ZackerySpytz
Copy link
Contributor Author

Serhiy, the check is already within a #ifdef NCURSES_MOUSE_VERSION block!

serhiy-storchaka
serhiy-storchaka reviewed Oct 14, 2020
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the documentation.

serhiy-storchaka
serhiy-storchaka requested changes Jan 6, 2021
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update Doc/library/curses.rst and Doc/whatsnew/3.10.rst.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ZackerySpytz
Copy link
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@serhiy-storchaka, @lisroach: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@serhiy-storchaka serhiy-storchaka merged commit 14cfa32 into python:master Jan 14, 2021
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@ZackerySpytz @adorilson
bpo-39273: Expose BUTTON5_* constants in the curses module if availab…
4784f64 
…le (pythonGH-17996)
@lancelote lancelote mentioned this pull request May 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@Yhg1s Yhg1s Awaiting requested review from Yhg1s

@lisroach lisroach Awaiting requested review from lisroach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZackerySpytz @bedevere-bot @serhiy-storchaka @lisroach @the-knights-who-say-ni