Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39369 Doc: Update mmap readline method documentation #17957

Merged
merged 2 commits into from
Feb 10, 2020
Merged

bpo-39369 Doc: Update mmap readline method documentation #17957

merged 2 commits into from
Feb 10, 2020

Conversation

Pardim93
Copy link
Contributor

@Pardim93 Pardim93 commented Jan 12, 2020

Update mmap readline method description. The fact that the readline method does update the file position should not be ignored since this might give the impression for the programmer that it doesn't update it.

https://bugs.python.org/issue39369

Update mmap `readline` method description. The fact that the `readline` method does update the file position should not be ignored since this might give the impression for the programmer that it doesn't update it.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Pardim93

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 12, 2020
@Pardim93 Pardim93 changed the title Doc: Update mmap readline method documentation 39369 Doc: Update mmap readline method documentation Jan 17, 2020
@Pardim93 Pardim93 changed the title 39369 Doc: Update mmap readline method documentation bpo-39369 Doc: Update mmap readline method documentation Jan 17, 2020
@Pardim93 Pardim93 requested review from vstinner and removed request for vstinner January 20, 2020 14:20
@KenanHArik
Copy link

Thanks @Pardim93. At PyCascade Sprint. I have reviewed this update for clarification and recommend this PR to get merged @willingc.

@willingc
Copy link
Contributor

Thanks @KenanHArik for reviewing this PR. Congrats @Pardim93 for your first contribution to CPython 🎉

@willingc willingc merged commit 6c9974e into python:master Feb 10, 2020
@Pardim93 Pardim93 deleted the update-mmap-doc branch February 10, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants