Repository navigation
Reorder entries in Misc/ACKS - #17663
Conversation
| Dan Lidral-Porter | ||
| Ngalim Siregar | ||
| Tim Gates | ||
| Karthikeyan Singaravelan No newline at end of file |
There was a problem hiding this comment.
12 lines added, 13 lines removed because Ngalim Siregar was already in the right spot.
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Thank you! I was going to do this myself, it was in my low priority list.
|
@merwok: Please replace |
|
Thanks @merwok for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
Sorry, @merwok, I could not cleanly backport this to |
|
Sorry @merwok, I had trouble checking out the |
|
GH-17672 is a backport of this pull request to the 3.7 branch. |
|
GH-17673 is a backport of this pull request to the 3.8 branch. |
|
Thanks for review. If the problem comes again, we could add a comment at the end of the file. |
|
Nice idea about a comment at the end of the file! |
|
Sorry, being the latest entry added by myself I read the sorted nature of the file at the top but didn't that it was sorted by last name expecting sorted by first name. It's a good idea to add the comment in the end about the same. I tried adding a check to Thanks. |
|
The order is not 100% exact, so I think trying to make an automated order would be hard (e.g. if there are three bits in the name, could be two first names or a two-part last name). Let me make a PR to add the comment at the end and add it to the backports PRs too (and please review these!) |
No description provided.