Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder entries in Misc/ACKS #17663

Merged
merged 3 commits into from
Dec 20, 2019
Merged

Reorder entries in Misc/ACKS #17663

merged 3 commits into from
Dec 20, 2019

Conversation

merwok
Copy link
Member

@merwok merwok commented Dec 19, 2019

No description provided.

Dan Lidral-Porter
Ngalim Siregar
Tim Gates
Karthikeyan Singaravelan
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12 lines added, 13 lines removed because Ngalim Siregar was already in the right spot.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I was going to do this myself, it was in my low priority list.

@merwok merwok merged commit dd1a20f into master Dec 20, 2019
@merwok merwok deleted the fix-misc-acks-sort branch December 20, 2019 14:53
@bedevere-bot
Copy link

@merwok: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @merwok for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @merwok, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker dd1a20f324d88f4171aca480b7972d68cab212c5 3.8

@miss-islington
Copy link
Contributor

Sorry @merwok, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker dd1a20f324d88f4171aca480b7972d68cab212c5 3.7

@bedevere-bot
Copy link

GH-17672 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-17673 is a backport of this pull request to the 3.8 branch.

@merwok
Copy link
Member Author

merwok commented Dec 20, 2019

Thanks for review. If the problem comes again, we could add a comment at the end of the file.

@serhiy-storchaka
Copy link
Member

Nice idea about a comment at the end of the file!

@tirkarthi
Copy link
Member

Sorry, being the latest entry added by myself I read the sorted nature of the file at the top but didn't that it was sorted by last name expecting sorted by first name. It's a good idea to add the comment in the end about the same. I tried adding a check to patchcheck.py since it already has a check for ACKs update to ensure the file stays sorted but hit some cases with unicode names having different value.

Thanks.

@merwok
Copy link
Member Author

merwok commented Dec 21, 2019

The order is not 100% exact, so I think trying to make an automated order would be hard (e.g. if there are three bits in the name, could be two first names or a two-part last name).

Let me make a PR to add the comment at the end and add it to the backports PRs too (and please review these!)

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants