-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-38870: Remove dead code related with argument unparsing #17613
Conversation
@@ -0,0 +1 @@ | |||
Remove dead code from ``ast._Unparser`` related with argument unparsing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove the NEWS entry. There is no user-facing change here :)
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again |
Thanks for making the requested changes! @pablogsal: please review the changes made to this pull request. |
Thanks for making the requested changes! @pablogsal: please review the changes made to this pull request. |
Disregard my latest message, I was looking at the wrong branch! (Reviewing on the phone is a suboptimal experience) 😂 |
Thanks for the PR! 🎉 |
It looks like there are no ways this code to fall down
first = False
block. Because of this statement;cpython/Lib/ast.py
Lines 1187 to 1189 in 94d2c8d
https://bugs.python.org/issue38870