Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38870: Remove dead code related with argument unparsing #17613

Merged
merged 2 commits into from
Dec 16, 2019

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented Dec 15, 2019

It looks like there are no ways this code to fall down first = False block. Because of this statement;

cpython/Lib/ast.py

Lines 1187 to 1189 in 94d2c8d

if node.vararg or node.kwonlyargs:
if first:
first = False

https://bugs.python.org/issue38870

@@ -0,0 +1 @@
Remove dead code from ``ast._Unparser`` related with argument unparsing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove the NEWS entry. There is no user-facing change here :)

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@isidentical
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

@pablogsal
Copy link
Member

pablogsal commented Dec 16, 2019

Disregard my latest message, I was looking at the wrong branch! (Reviewing on the phone is a suboptimal experience) 😂

@pablogsal pablogsal merged commit a322f50 into python:master Dec 16, 2019
@pablogsal
Copy link
Member

Thanks for the PR! 🎉

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants