Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32894: Support unparsing of infinity numbers in ast_unparser.c #17426

Merged
merged 12 commits into from
Apr 13, 2020
Merged

bpo-32894: Support unparsing of infinity numbers in ast_unparser.c #17426

merged 12 commits into from
Apr 13, 2020

Conversation

isidentical
Copy link
Member

@isidentical isidentical commented Dec 1, 2019 •
edited by bedevere-bot
Loading

serhiy-storchaka
serhiy-storchaka previously requested changes Dec 1, 2019
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@isidentical
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka reviewed Dec 1, 2019
View reviewed changes
pablogsal
pablogsal requested changes Dec 2, 2019
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@isidentical
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@pablogsal, @serhiy-storchaka: please review the changes made to this pull request.

@isidentical isidentical force-pushed the bpo-32894 branch 2 times, most recently from 3c9c439 to 3ed11d3 Compare December 3, 2019 14:49
vstinner
vstinner reviewed Dec 14, 2019
View reviewed changes
vstinner
vstinner reviewed Dec 17, 2019
View reviewed changes
vstinner
vstinner reviewed Dec 17, 2019
View reviewed changes
vstinner
vstinner reviewed Jan 13, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is almost good. Just two last minor remarks. I'm not sure why interning was used in the first place. Does someone recall the rationale for interning strings?

vstinner
vstinner reviewed Jan 13, 2020
View reviewed changes
@isidentical isidentical force-pushed the bpo-32894 branch 2 times, most recently from c719152 to eeb8328 Compare March 31, 2020 17:55
@isidentical
Copy link
Member Author

@vstinner @serhiy-storchaka can I get a re-review (or possibly a merge) for this. This is blocking me on another bugfix related C unparser.

vstinner
vstinner approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner dismissed serhiy-storchaka’s stale review April 13, 2020 22:50

@isidentical addressed Serhiy's review.

@vstinner vstinner merged commit 258f517 into python:master Apr 13, 2020
@vstinner
Copy link
Member

Merged, thanks @isidentical!

@isidentical
Copy link
Member Author

Thank you for merge @vstinner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@isidentical @bedevere-bot @vstinner @serhiy-storchaka @pablogsal @the-knights-who-say-ni