-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
Enable travis on fork branches with normalized naming scheme #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1. If people want to test something on their fork before opening a PR, I think they can edit .travis.yml
on their fork. Note that if your patch is not ready for code review yet and you want to run the test suite on Travis, it's perfectly fine to open a PR and add "[WIP]" prefix to the PR title.
Also, people can name their branches differently and we can't add every different naming scheme to travis.yml
.
I agree with @berkerpeksag . FWI, you can create pull request in your fork to run Travis. |
I and @ncoghlan were discussing about this during PyCon Pune sprints for enabling travis for atleast some naming schemes, without explicity editing |
I like @methane's idea of suggesting that folks create local PRs in their fork in order to trigger Travis without maintaining a WIP PR against the main CPython repo. @aktech: Would you mind browsing through the developer guide looking for a section where it may make sense to add a new subsection talking about this, and then file a suggestion (or PR!) about recommending that approach? The Developer Guide repo and issue tracker is at https://docs.python.org/devguide/ |
A recently introduced test case (see Stackless issue python#150) was buggy. It assumed sizeof(size_t) == sizeof(long) which is false on Windows x64.
Currently the travis runs on master and branches like 2.7, 3.2, (number.number), which prevents running travis on fork branches which have custom names. This PR introduces a normalized naming scheme for branches:
bpo-32368238
(bpo-some_number). So as to enable running travis on fork branches with this naming scheme.This could help the contributors in testing on their own travis.
For example: https://travis-ci.org/aktech/cpython/builds/203125688