Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38897: Remove use of deprecated array.fromstring method #17332

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

dcoles
Copy link
Contributor

@dcoles dcoles commented Nov 22, 2019

Using array.fromstring generates a DeprecationWarning on current versions of Python.

https://bugs.python.org/issue38897

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@dcoles

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@corona10
Copy link
Member

@dcoles Thanks for the contribution.
Before processing the code review, Would you like to create an issue for this PR on bugs.python.org?

Thank you :)

@dcoles dcoles changed the title Remove use of deprecated array.fromstring method bpo-38897: Remove use of deprecated array.fromstring method Nov 22, 2019
Using `array.fromstring` generates a `DeprecationWarning` on current versions of Python.
@dcoles
Copy link
Contributor Author

dcoles commented Nov 22, 2019

@corona10 Issue on bugs.python.org: https://bugs.python.org/issue38897

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcoles

Thanks for the contribution to the CPython project!!
PR looks good to me :)

@vstinner @serhiy-storchaka
Dear core developers,
@dcoles is the first time contributor to this project.
Please take a look at his PR when you have a time :)
This PR is simple and clear, so it is expected to take less time to review.

@miss-islington
Copy link
Contributor

Thanks @dcoles for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 26, 2019
(cherry picked from commit 386d00c)

Co-authored-by: David Coles <coles.david@gmail.com>
@bedevere-bot
Copy link

GH-17386 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Nov 26, 2019
(cherry picked from commit 386d00c)

Co-authored-by: David Coles <coles.david@gmail.com>
@tirkarthi
Copy link
Member

@methane Could this be backported to 3.8 too?

@methane
Copy link
Member

methane commented Nov 26, 2019

Oh, I missed it. Thank you.

@miss-islington
Copy link
Contributor

Thanks @dcoles for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-17387 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 26, 2019
(cherry picked from commit 386d00c)

Co-authored-by: David Coles <coles.david@gmail.com>
miss-islington added a commit that referenced this pull request Nov 26, 2019
(cherry picked from commit 386d00c)

Co-authored-by: David Coles <coles.david@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants