-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-38897: Remove use of deprecated array.fromstring
method
#17332
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
@dcoles Thanks for the contribution. Thank you :) |
array.fromstring
methodarray.fromstring
method
Using `array.fromstring` generates a `DeprecationWarning` on current versions of Python.
@corona10 Issue on bugs.python.org: https://bugs.python.org/issue38897 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution to the CPython project!!
PR looks good to me :)
@vstinner @serhiy-storchaka
Dear core developers,
@dcoles is the first time contributor to this project.
Please take a look at his PR when you have a time :)
This PR is simple and clear, so it is expected to take less time to review.
(cherry picked from commit 386d00c) Co-authored-by: David Coles <coles.david@gmail.com>
GH-17386 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit 386d00c) Co-authored-by: David Coles <coles.david@gmail.com>
@methane Could this be backported to 3.8 too? |
Oh, I missed it. Thank you. |
GH-17387 is a backport of this pull request to the 3.8 branch. |
(cherry picked from commit 386d00c) Co-authored-by: David Coles <coles.david@gmail.com>
(cherry picked from commit 386d00c) Co-authored-by: David Coles <coles.david@gmail.com>
Using
array.fromstring
generates aDeprecationWarning
on current versions of Python.https://bugs.python.org/issue38897