Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-22367: Update test_fcntl.py for spawn process mode #17154

Merged
merged 2 commits into from
Nov 19, 2019
Merged

bpo-22367: Update test_fcntl.py for spawn process mode #17154

merged 2 commits into from
Nov 19, 2019

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Nov 14, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Nov 14, 2019
@corona10 corona10 added skip issue skip news and removed awaiting review tests Tests in the Lib/test dir labels Nov 14, 2019
@corona10 corona10 requested a review from vstinner November 14, 2019 16:19
@corona10
Copy link
Member Author

@vstinner I've checked both Linux and mac works as expected on this test.
Please take a look

@corona10 corona10 changed the title bpo-22367: Update process start_method of test_fcntl.py for macOS [WIP]bpo-22367: Update process start_method of test_fcntl.py for macOS Nov 14, 2019
@corona10 corona10 changed the title [WIP]bpo-22367: Update process start_method of test_fcntl.py for macOS bpo-22367: Update test_fcntl.py Nov 14, 2019
@corona10 corona10 changed the title bpo-22367: Update test_fcntl.py bpo-22367: Update test_fcntl.py for spawn process mode Nov 14, 2019
@corona10 corona10 requested a review from zooba November 16, 2019 16:44
@corona10
Copy link
Member Author

I add @zooba as the reviewer also. Since https://bugs.python.org/issue38790 was reported also.

zooba
zooba approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to fix the tests as far as Azure Pipelines is concerned.

I have no familiarity with what this is actually doing though, so I can't say whether the test is still valid. Get a second approval besides mine before merging.

@ambv ambv merged commit 9960230 into python:master Nov 19, 2019
@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @corona10 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-17252 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2019
@corona10 @miss-islington
bpo-22367: Update test_fcntl.py for spawn process mode (pythonGH-17154)
4fa2ec1 
(cherry picked from commit 9960230)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot
Copy link

GH-17253 is a backport of this pull request to the 3.7 branch.

vstinner pushed a commit that referenced this pull request Nov 22, 2019
@miss-islington @corona10 @vstinner
bpo-22367: Update test_fcntl.py for spawn process mode (GH-17154) (GH…
c3cd0de 
…-17252)

(cherry picked from commit 9960230)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
vstinner pushed a commit that referenced this pull request Nov 22, 2019
@miss-islington @corona10 @vstinner
bpo-22367: Update test_fcntl.py for spawn process mode (GH-17154) (GH…
d4d7920 
…-17253)

(cherry picked from commit 9960230)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@corona10
bpo-22367: Update test_fcntl.py for spawn process mode (python#17154)
af5afa1
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@corona10 @shihai1991
bpo-22367: Update test_fcntl.py for spawn process mode (python#17154)
258fa19
@AndrewLutomirski AndrewLutomirski mannequin mentioned this pull request Mar 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba approved these changes

@vstinner vstinner Awaiting requested review from vstinner

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@corona10 @bedevere-bot @miss-islington @zooba @ambv @the-knights-who-say-ni