Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-26353: IDLE adds an unneeded newline when saving a shell window #17103

Merged
merged 4 commits into from
Nov 12, 2019
Merged

bpo-26353: IDLE adds an unneeded newline when saving a shell window #17103

merged 4 commits into from
Nov 12, 2019

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Nov 10, 2019 •
edited by bedevere-bot
Loading

IDLE no longer adds an unneeded newline when saving a shell window.

https://bugs.python.org/issue26353

terryjreedy
terryjreedy approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding the key idea needed. I rearranged things a bit and added tests (which was part of the reason for the rearrangement).

@terryjreedy terryjreedy added needs backport to 3.7 type-bug An unexpected behavior, bug, or error labels Nov 12, 2019
@terryjreedy terryjreedy merged commit c8b53dc into python:master Nov 12, 2019
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-17118 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-17119 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2019
@ZackerySpytz @miss-islington
bpo-26353: IDLE adds an unneeded newline when saving a shell window (p…
d41398c 
…ythonGH-17103)

(cherry picked from commit c8b53dc)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Nov 12, 2019
@miss-islington @ZackerySpytz
bpo-26353: IDLE adds an unneeded newline when saving a shell window (G…
177b126 
…H-17103)

(cherry picked from commit c8b53dc)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Nov 12, 2019
@miss-islington @ZackerySpytz
bpo-26353: IDLE adds an unneeded newline when saving a shell window (G…
8ce1a9c 
…H-17103)

(cherry picked from commit c8b53dc)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@ZackerySpytz
bpo-26353: IDLE adds an unneeded newline when saving a shell window (p…
340ee9f 
…ythonGH-17103)
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@ZackerySpytz @shihai1991
bpo-26353: IDLE adds an unneeded newline when saving a shell window (p…
d486739 
…ythonGH-17103)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ZackerySpytz @miss-islington @bedevere-bot @terryjreedy @the-knights-who-say-ni