Skip to content

Fix definition of multiple ']' in header #17086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix definition of multiple ']' in header #17086

wants to merge 2 commits into from

Conversation

mark99i
Copy link

@mark99i mark99i commented Nov 7, 2019

Fix definition of multiple ']' in header in configparser

in old version in example header is "[i love [python] lang]"
parse as "i love [python", only up to the first character ']'.

once fixed, multiple ']' can be used and this will not cause the header to be clipped.
now saving works correctly, but reading does not

in old version in example header is "[i love [python] lang]"
parse as "i love [python", only up to the first character ']'.

once fixed, multiple ']' can be used and this will not cause the header to be clipped. 
now saving works correctly, but reading does not
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@mark99i

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @mark99i, but I think this PR should be closed in favor of #17129, since it includes tests and doesn't break handling on the empty case.

Please make sure to include the "bpo-#####: " prefix in the PR title next time so that it properly links to the issue and others can see that you've begun work.

@brandtbucher
Copy link
Member

Thanks for your time though... definitely looking forward to seeing more contributions from you in the future!

@brandtbucher brandtbucher added type-feature A feature request or enhancement type-bug An unexpected behavior, bug, or error and removed type-feature A feature request or enhancement labels Nov 13, 2019
@mark99i mark99i closed this Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants