Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38652: Remove provisional note for asyncio.BufferedProtocol #17047

Merged
merged 3 commits into from
Dec 7, 2019

Conversation

Anj-A
Copy link
Contributor

@Anj-A Anj-A commented Nov 4, 2019

@Anj-A Anj-A requested review from 1st1 and asvetlov as code owners November 4, 2019 17:36
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Anj-A

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@JamoBox
Copy link
Contributor

JamoBox commented Nov 4, 2019

@Anj-A
Are you sure this is the right BPO issue number? Looks like it should be under bpo-38652

Copy link
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Anj-A, this looks exactly as I described in the issue, with removing the provisional note while retaining a versionadded note. I'll add a label to backport it to the 3.8 branch as well.

@aeros
Copy link
Contributor

aeros commented Nov 4, 2019

Also, if you could update the PR title to be more specifically descriptive of the changes made, that would be helpful. The actual changes made are correct though.

The only thing remaining after that is for the CLA to be signed and processed, but that usually only takes around 24-48 hours.

@ilevkivskyi ilevkivskyi changed the title bpo-37838: Doc change bpo-38652: Doc change Nov 11, 2019
@Anj-A Anj-A changed the title bpo-38652: Doc change bpo-38652: Remove provisional note for asyncio.BufferedProtocol Nov 12, 2019
@Anj-A
Copy link
Contributor Author

Anj-A commented Nov 12, 2019

Have signed the CLA and updated the title as suggested.

@Anj-A
Copy link
Contributor Author

Anj-A commented Nov 20, 2019

Hi, could you please get this PR approved if everything looks fine? @1st1 @asvetlov

@miss-islington
Copy link
Contributor

Thanks @Anj-A for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@asvetlov
Copy link
Contributor

asvetlov commented Dec 7, 2019

Thanks!

@asvetlov
Copy link
Contributor

asvetlov commented Dec 8, 2019

The fix should not be backported to 3.8, that's perfectly fine if 3.8 still states that BufferedProtocol is still provisional.
Changing something in 3.8.1 is worse than keeping the status quo until 3.9

@aeros
Copy link
Contributor

aeros commented Dec 9, 2019

@asvetlov

The fix should not be backported to 3.8, that's perfectly fine if 3.8 still states that BufferedProtocol is still provisional.

Okay, I'll remove the backport label then.

Does this also apply to other provisional APIs as well, as in they remain provisional for the major version they were released on?

@asvetlov
Copy link
Contributor

asvetlov commented Dec 9, 2019

I doubt if we have a strong rule for the provisional status cleanup.
I only recall discussions for removal something in 3.X, and never for 3.X.Y.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants