Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-38657: Clarify numeric padding behaviour in string formatting #17036

Merged
merged 5 commits into from
Feb 21, 2020
+3 −2
Merged

bpo-38657: Clarify numeric padding behaviour in string formatting #17036

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8791235
bpo-38657 Clarify numeric padding behaviour
JamoBox Nov 3, 2019
f5c9930
Be more explicit about the signs
JamoBox Nov 4, 2019
4996e98
Fix line wrapping.
JamoBox Nov 4, 2019
050da92
Revert "Fix line wrapping."
JamoBox Nov 4, 2019
3ef7a99
Fix line wrapping.
JamoBox Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix line wrapping. 
Signed-off-by: Pete Wicken <petewicken@gmail.com>
@JamoBox
JamoBox committed Nov 4, 2019
commit 4996e984b1b75b3d10076637f79cb7e30e23833f
4 changes: 2 additions & 2 deletions Doc/library/string.rst
View file
Original file line number Diff line number Diff line change
@@ -416,8 +416,8 @@ error.
Added the ``'_'`` option (see also :pep:`515`).

*width* is a decimal integer defining the minimum total field width,
including any prefixes, separators, and other formatting characters. If not specified, then the field width will be
determined by the content.
including any prefixes, separators, and other formatting characters.
If not specified, then the field width will be determined by the content.

When no explicit alignment is given, preceding the *width* field by a zero
(``'0'``) character enables
2 changes: 1 addition & 1 deletion Python/formatter_unicode.c
View file
Original file line number Diff line number Diff line change
@@ -529,7 +529,7 @@ calc_number_widths(NumberFieldWidths *spec, Py_ssize_t n_prefix,
/* min_width can go negative, that's okay. format->width == -1 means
we don't care. */
if (format->fill_char == '0' && format->align == '=')
spec->n_min_width = format->width - n_non_digit_non_padding;
spec->n_min_width = format->width + n_non_digit_non_padding;
else
spec->n_min_width = 0;