-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-30361: Use better example for mixed-type operands #1701
Conversation
@gfyoung, thanks for your PR! By analyzing the history of the files in this pull request, we identified @serhiy-storchaka, @ezio-melotti and @birkenfeld to be potential reviewers. |
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
I just had it signed approximately an hour ago. How long does it take to propagate? |
Doc/tutorial/introduction.rst
Outdated
7.5 | ||
>>> 7.0 / 2 | ||
3.5 | ||
>>> 3 * 3.75 - 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't be better to use the example that takes the integer result? There is nothing unexpected that 3 * 3.75
results a float
, it can't be an int
. But 4 * 3.75
is an integer of type float
even if it can be represented as int
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Fixed.
.gitignore
Outdated
@@ -1,8 +1,10 @@ | |||
# Two-trick pony for OSX and other case insensitive file systems: | |||
# Ignore ./python binary on Unix but still look into ./Python/ directory. | |||
.idea/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Will put in separate PR.
@serhiy-storchaka : Do you have any updates on this? |
Title is self-explanatory. If this patch is accepted, I can also backport to the 3.6 branch.