bpo-38600: Change the mark up of NULL in the C API documentation. #16950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace all *NULL* with ``NULL``.
serhiy-storchaka
added
docs
serhiy-storchaka
requested review from
1st1,
abalkin,
pganssle and
tiran
as code owners
ammaraskar
reviewed
Oct 28, 2019
| @@ -150,7 +150,7 @@ PyAPI_FUNC(PyObject *) PyObject_CallNoArgs(PyObject *func); | |||
| /* Call a callable Python object 'callable' with arguments given by the | |||
| tuple 'args' and keywords arguments given by the dictionary 'kwargs'. | |||
|
|
|||
| 'args' must not be *NULL*, use an empty tuple if no arguments are | |||
There was a problem hiding this comment.
Is this replacement intentional? This seems to be outside the docs.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry @serhiy-storchaka, I had trouble checking out the |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Oct 30, 2019
…n. (pythonGH-16950) Replace all *NULL* with ``NULL``.. (cherry picked from commit 25fc088) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Oct 30, 2019
…n. (pythonGH-16950) Replace all *NULL* with ``NULL``.. (cherry picked from commit 25fc088) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-16999 is a backport of this pull request to the 3.8 branch. |
|
GH-17000 is a backport of this pull request to the 3.7 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 30, 2019
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 30, 2019
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
…thonGH-16950) Replace all *NULL* with ``NULL``.
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
…thonGH-16950) Replace all *NULL* with ``NULL``.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all
*NULL*with``NULL``.https://bugs.python.org/issue38600