Skip to content

bpo-38493: Add os.CLD_KILLED and CLD_STOPPED for os #16821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 21, 2019
Merged

bpo-38493: Add os.CLD_KILLED and CLD_STOPPED for os #16821

merged 6 commits into from
Oct 21, 2019

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Oct 16, 2019 •
edited by bedevere-bot
Loading

@corona10 corona10 changed the title bpo-38493: Add os.CLD_KILLED for posix module [WiIP]bpo-38493: Add os.CLD_KILLED for posix module Oct 16, 2019
@corona10 corona10 changed the title [WiIP]bpo-38493: Add os.CLD_KILLED for posix module [WIP]bpo-38493: Add os.CLD_KILLED for posix module Oct 16, 2019
serhiy-storchaka
serhiy-storchaka reviewed Oct 16, 2019
View reviewed changes
@corona10 corona10 changed the title [WIP]bpo-38493: Add os.CLD_KILLED for posix module [WIP]bpo-38493: Add os.CLD_KILLED and CLD_STOPPED for posix module Oct 16, 2019
@corona10 corona10 changed the title [WIP]bpo-38493: Add os.CLD_KILLED and CLD_STOPPED for posix module bpo-38493: Add os.CLD_KILLED and CLD_STOPPED for posix module Oct 16, 2019
@corona10 corona10 changed the title bpo-38493: Add os.CLD_KILLED and CLD_STOPPED for posix module bpo-38493: Add os.CLD_KILLED and CLD_STOPPED for os Oct 16, 2019
serhiy-storchaka
serhiy-storchaka reviewed Oct 16, 2019
View reviewed changes
Lib/test/test_posix.py Outdated
@unittest.skipUnless(hasattr(signal, 'SIGCHLD'), 'CLD_XXXX be placed in si_code for a SIGCHLD signal')
@unittest.skipUnless(hasattr(os, 'waitid_result'), "test needs os.waitid_result")
def test_cld_xxxx_constants(self):
# reference: http://man7.org/linux/man-pages/man2/sigaction.2.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These names are not Linux specific, and on other OSes they can have other values.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These names are not Linux specific, and on other OSes they can have other values.

I 've updated the unit test.
Please let me know if you have better ideas.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux: http://man7.org/linux/man-pages/man2/sigaction.2.html
BSD: https://www.freebsd.org/cgi/man.cgi?query=siginfo&sektion=3&apropos=0&manpath=FreeBSD+7.1-RELEASE
Apple: https://opensource.apple.com/source/xnu/xnu-344/bsd/sys/signal.h

Is it enough to check hasattr(signal, 'SIGCHLD')?

@corona10
Copy link
Member Author

@serhiy-storchaka
The documentation said that

These are the possible values for si_code in the result returned by waitid().

I think that checking hasattr(os, 'waitid_result') and hasattr(signal, 'SIGCHLD') for unit test
is proper.

What do you think?

serhiy-storchaka
serhiy-storchaka reviewed Oct 21, 2019
View reviewed changes
Lib/test/test_posix.py Outdated
@unittest.skipUnless(hasattr(signal, 'SIGCHLD'), 'CLD_XXXX be placed in si_code for a SIGCHLD signal')
@unittest.skipUnless(hasattr(os, 'waitid_result'), "test needs os.waitid_result")
def test_cld_xxxx_constants(self):
self.assertTrue(hasattr(os, 'CLD_EXITED'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is enough to just get an attribute:

        os.CLD_EXITED

These constants are a part of Posix, but I am not sure that they are implemented in all Unixes (as you see, some was not implemented in old Linux). In particularly, I have doubts about AIX. But let try.

@serhiy-storchaka serhiy-storchaka merged commit 2eba6ad into python:master Oct 21, 2019
@corona10 corona10 deleted the bpo-38373 branch October 21, 2019 12:19
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@corona10
bpo-38493: Add os.CLD_KILLED and os.CLD_STOPPED. (pythonGH-16821)
6c3d996
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@corona10 @shihai1991
bpo-38493: Add os.CLD_KILLED and os.CLD_STOPPED. (pythonGH-16821)
86b8eb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corona10 @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot