Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo: update variable name in asyncio-sync docs #16716

Closed
wants to merge 1 commit into from
Closed

Typo: update variable name in asyncio-sync docs #16716

wants to merge 1 commit into from

Conversation

goswami-rahul
Copy link

rename lock -> cond as the example is trying to show usage of Condition.

rename `lock` -> 'cond` as the example is trying to show usage of `Condition`
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@goswami-rahul

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 11, 2019
@goswami-rahul goswami-rahul changed the title Typoupdate variable name in asyncio-sync docs Typo: update variable name in asyncio-sync docs Oct 11, 2019
@brandtbucher
Copy link
Member

Thanks for your time @goswami-rahul, and welcome to CPython! I assume you've seen the bot's message about the CLA?

It looks like this change wasn't backported to 3.7 when it was made in d73ac0e. Maybe somebody can clarify what we do in this situation?

@brandtbucher
Copy link
Member

@lisroach

@lisroach
Copy link
Contributor

Oops, thanks for pointing this out @brandtbucher . I am going to try to backport the original in #16720, this PR should be closed. Thanks for the fix @goswami-rahul, look forward to seeing you around CPython!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants