Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38407: Add docstrings for typing.SupportsXXX classes. #16644

Merged
merged 1 commit into from
Oct 8, 2019
Merged

bpo-38407: Add docstrings for typing.SupportsXXX classes. #16644

merged 1 commit into from
Oct 8, 2019

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 8, 2019 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Oct 8, 2019
ilevkivskyi
ilevkivskyi approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@serhiy-storchaka serhiy-storchaka merged commit 8252c52 into python:master Oct 8, 2019
@serhiy-storchaka serhiy-storchaka deleted the typing-doc-supportxxx branch October 8, 2019 13:30
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8252c52e57283515ace5d4251584255dc5c60eb5 3.8

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8252c52e57283515ace5d4251584255dc5c60eb5 3.7

@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2019
@serhiy-storchaka @miss-islington
bpo-38407: Add docstrings for typing.SupportsXXX classes. (pythonGH-1…
dade081 
…6644)

(cherry picked from commit 8252c52)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-16656 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 8, 2019
@miss-islington @serhiy-storchaka
bpo-38407: Add docstrings for typing.SupportsXXX classes. (GH-16644)
7162440 
(cherry picked from commit 8252c52)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-16673 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 9, 2019
@serhiy-storchaka
[3.7] bpo-38407: Add docstrings for typing.SupportsXXX classes. (pyth…
2a505df 
…onGH-16644).

(cherry picked from commit 8252c52)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Oct 9, 2019
@serhiy-storchaka
[3.7] bpo-38407: Add docstrings for typing.SupportsXXX classes. (GH-1…
0b354fc 
…6644). (GH-16673)

(cherry picked from commit 8252c52)
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@serhiy-storchaka
bpo-38407: Add docstrings for typing.SupportsXXX classes. (pythonGH-1…
3690b0a 
…6644)
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees
No one assigned
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @miss-islington @bedevere-bot @ilevkivskyi @the-knights-who-say-ni