-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-27103: regrtest disables -W if -R is used #1651
Conversation
Workaround for a regrtest bug.
@Haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @zooba and @abalkin to be potential reviewers. |
This change is not a proper fix, just a workaround to be able to move forward on the new "Refleaks" buildbot that @zware just created: |
I think I'd rather change the builder config, possibly by adding a new make target for it ( |
I was bitten multiple timed by this bug. The rationale is non obvious. I
would like to fix it.
|
Ok, fair enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you add a test for this? It should be easy in ParseArgsTestCase.
I don't know whether it is worth to make this an error rather than a warning.
Could you add a test for this? It should be easy in ParseArgsTestCase
Since it's a temporary workaround, I don't want to write a test for it.
I'm quite sure that it's possible to really fix the bug by reorganizing the
code.
|
Workaround for a regrtest bug.