Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-27103: regrtest disables -W if -R is used #1651

Merged
merged 1 commit into from
May 18, 2017
Merged

bpo-27103: regrtest disables -W if -R is used #1651

merged 1 commit into from
May 18, 2017

Conversation

vstinner
Copy link
Member

Workaround for a regrtest bug.

Workaround for a regrtest bug.
@mention-bot
Copy link

@Haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brettcannon, @zooba and @abalkin to be potential reviewers.

@vstinner
Copy link
Member Author

This change is not a proper fix, just a workaround to be able to move forward on the new "Refleaks" buildbot that @zware just created:
http://buildbot.python.org/all/builders/x86%20Gentoo%20Refleaks%203.6/

@zware
Copy link
Member

zware commented May 18, 2017

I think I'd rather change the builder config, possibly by adding a new make target for it (make refleaktest?).

@vstinner
Copy link
Member Author

vstinner commented May 18, 2017 via email

@zware
Copy link
Member

zware commented May 18, 2017

Ok, fair enough.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you add a test for this? It should be easy in ParseArgsTestCase.

I don't know whether it is worth to make this an error rather than a warning.

@vstinner
Copy link
Member Author

vstinner commented May 18, 2017 via email

@vstinner vstinner merged commit fcdd9b6 into python:master May 18, 2017
@vstinner vstinner deleted the regrtest_R branch May 18, 2017 20:03
vstinner added a commit that referenced this pull request May 18, 2017
Workaround for a regrtest bug.
(cherry picked from commit fcdd9b6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants