Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38019: correctly handle pause/resume reading of closed asyncio unix pipe #16472

Merged
merged 3 commits into from
Sep 29, 2019
Merged

bpo-38019: correctly handle pause/resume reading of closed asyncio unix pipe #16472

merged 3 commits into from
Sep 29, 2019

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Sep 29, 2019 •
edited by bedevere-bot
Loading

@asvetlov asvetlov requested a review from 1st1 as a code owner September 29, 2019 10:51
@asvetlov
Copy link
Contributor Author

Now these methods are handled the same way as sockets in selector_events.py

@asvetlov asvetlov merged commit 58498bc into python:master Sep 29, 2019
@asvetlov asvetlov deleted the double-pausing-pipe branch September 29, 2019 12:00
@miss-islington
Copy link
Contributor

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2019
@asvetlov @miss-islington
bpo-38019: correctly handle pause/resume reading of closed asyncio un…
a72032b 
…ix pipe (pythonGH-16472)

(cherry picked from commit 58498bc)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@bedevere-bot
Copy link

GH-16473 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-16474 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2019
@asvetlov @miss-islington
bpo-38019: correctly handle pause/resume reading of closed asyncio un…
ef2c2e8 
…ix pipe (pythonGH-16472)

(cherry picked from commit 58498bc)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
miss-islington added a commit that referenced this pull request Sep 29, 2019
@miss-islington @asvetlov
bpo-38019: correctly handle pause/resume reading of closed asyncio un…
1c3e469 
…ix pipe (GH-16472)

(cherry picked from commit 58498bc)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
miss-islington added a commit that referenced this pull request Sep 29, 2019
@miss-islington @asvetlov
bpo-38019: correctly handle pause/resume reading of closed asyncio un…
19cd595 
…ix pipe (GH-16472)

(cherry picked from commit 58498bc)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@asvetlov
bpo-38019: correctly handle pause/resume reading of closed asyncio un…
46f2ef9 
…ix pipe (pythonGH-16472)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asvetlov @miss-islington @bedevere-bot @the-knights-who-say-ni