Skip to content

[3.8] bpo-38270: Check for hash digest algorithms and avoid MD5 (GH-16382) #16393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 25, 2019

Make it easier to run and test Python on systems with restrict crypto policies:

  • add requires_hashdigest to test.support to check if a hash digest algorithm is available and working
  • avoid MD5 in test_hmac
  • replace MD5 with SHA256 in test_tarfile
  • mark network tests that require MD5 for MD5-based digest auth or CRAM-MD5

https://bugs.python.org/issue38270
(cherry picked from commit c64a1a6)

Co-authored-by: Christian Heimes christian@python.org

https://bugs.python.org/issue38270

Automerge-Triggered-By: @tiran

…6382)

Make it easier to run and test Python on systems with restrict crypto policies:

* add requires_hashdigest to test.support to check if a hash digest algorithm is available and working
* avoid MD5 in test_hmac
* replace MD5 with SHA256 in test_tarfile
* mark network tests that require MD5 for MD5-based digest auth or CRAM-MD5

https://bugs.python.org/issue38270
(cherry picked from commit c64a1a6)

Co-authored-by: Christian Heimes <christian@python.org>
@miss-islington
Copy link
Contributor Author

@tiran: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@tiran: Status check is done, and it's a success ✅ .

Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge

@miss-islington miss-islington merged commit 66cd041 into python:3.8 Sep 25, 2019
@miss-islington miss-islington deleted the backport-c64a1a6-3.8 branch September 25, 2019 15:50
@miss-islington
Copy link
Contributor Author

@tiran: Status check is done, and it's a success ✅ .

stratakis pushed a commit to stratakis/cpython that referenced this pull request Dec 2, 2019
…onGH-16382) (pythonGH-16393)

Make it easier to run and test Python on systems with restrict crypto policies:

* add requires_hashdigest to test.support to check if a hash digest algorithm is available and working
* avoid MD5 in test_hmac
* replace MD5 with SHA256 in test_tarfile
* mark network tests that require MD5 for MD5-based digest auth or CRAM-MD5

https://bugs.python.org/issue38270
(cherry picked from commit c64a1a6)

Co-authored-by: Christian Heimes <christian@python.org>

https://bugs.python.org/issue38270

Automerge-Triggered-By: @tiran
stratakis pushed a commit to stratakis/cpython that referenced this pull request May 5, 2020
…onGH-16382) (pythonGH-16393)

Make it easier to run and test Python on systems with restrict crypto policies:

* add requires_hashdigest to test.support to check if a hash digest algorithm is available and working
* avoid MD5 in test_hmac
* replace MD5 with SHA256 in test_tarfile
* mark network tests that require MD5 for MD5-based digest auth or CRAM-MD5

https://bugs.python.org/issue38270
(cherry picked from commit c64a1a6)

Co-authored-by: Christian Heimes <christian@python.org>

https://bugs.python.org/issue38270

Automerge-Triggered-By: @tiran
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants