Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yes, comment]: https://github.com/python/cpython/pull/1631#issuecomment-1323966537 #1631

Merged
merged 1 commit into from
May 17, 2017

Conversation

zooba
Copy link
Member

@zooba zooba commented May 17, 2017

No impact on build - just to help keep the source tree cleaner.

@zooba zooba added the trivial label May 17, 2017
@zooba zooba requested a review from zware May 17, 2017 18:02
@zooba zooba merged commit 4486a09 into python:master May 17, 2017
@zooba zooba deleted the vcxproj-encoding branch May 17, 2017 20:06
@encukou
Copy link
Member

encukou commented Nov 22, 2022

Hi Steve,
AFAIK, these files also need other things that not all editors preserve:

  • Windows-style newlines
  • no final end-of-line character at the end of the file

Or is that a cargo-culting nowadays? (Asking you sounds be easier than spinning up buildbots.)
I can add a script to fix all these+encodings, and plug it into make regen-all (even though it's not really generation). If that sounds good, I'll open a new issue.

@zooba
Copy link
Member Author

zooba commented Nov 22, 2022

I don't think it needs to be plugged in anywhere, there haven't been any issues that I've noticed.

Mainly what happens is when people are working in VS, often when you build it's going to save the project file and show up in a git diff for whitespace changes.

Maybe patchcheck (does anyone still run that?) is the right place? Or .gitattributes might be capable enough?

@zooba
Copy link
Member Author

zooba commented Nov 22, 2022

But yes, they should still be UTF-8 BOM files with CRLF endings, as far as I'm aware. Windows is generally getting better at going "oh this is a POSIX developer, let's leave things their way for them", but I'm not sure if VS has caught up to that yet.

@encukou encukou changed the title Fixes encodings in vcxproj files and adds script to automatically do it. [yes, comment]: https://github.com/python/cpython/pull/1631#issuecomment-1323966537 Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants