bpo-38108: Makes mock objects inherit from Base #16060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisroach
requested review from
gvanrossum,
ilevkivskyi,
tiran and
a team
as code owners
|
Oops, didn't mean to do that |
lisroach
force-pushed
the
issue38108
branch
from
f4cbc87 to
94f0c8d
Compare
|
Thanks @lisroach for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 29, 2019
(cherry picked from commit 9a7d951) Co-authored-by: Lisa Roach <lisaroach14@gmail.com>
|
GH-16470 is a backport of this pull request to the 3.8 branch. |
lisroach
pushed a commit
that referenced
this pull request
Sep 30, 2019
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the few Mock classes that do not inherit from Base to properly inherit from base. Updates the super() calls that should go with them as well.
That was all I planned on doing with this diff, but the changes to get AsyncMock inheritance working right with subclasses was so linked with this diff I merged it into one to prevent temporary breaking changes.
https://bugs.python.org/issue38108