Skip to content

bpo-33166: Change os.cpu_count to return active (real) processors #15949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2019
Merged

bpo-33166: Change os.cpu_count to return active (real) processors #15949

merged 3 commits into from
Sep 11, 2019

Conversation

@zooba
Copy link
Member

@zooba zooba commented Sep 11, 2019 •
edited by bedevere-bot
Loading

@zooba zooba added type-bug An unexpected behavior, bug, or error OS-windows needs backport to 3.8 labels Sep 11, 2019
@zooba
Copy link
Member Author

zooba commented Sep 11, 2019

Note that I added the prototype rather than changing the Windows version in pyconfig.h. This is so it's safe to backport to 3.8.

In a later PR I'll update the API version.

zware
zware requested changes Sep 11, 2019
View reviewed changes
@bedevere-bot
Copy link

bedevere-bot commented Sep 11, 2019

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@zooba
Copy link
Member Author

zooba commented Sep 11, 2019

I don't want to backport the WINNT_VER change because we have so much stuff that tries to auto-detect macros, and that may introduce new macros. It's a little late in the release cycle for that.

@zooba
Copy link
Member Author

zooba commented Sep 11, 2019 •
edited
Loading

I have made the requested changes; please review again

Ping @zware

zware
zware approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zooba zooba mentioned this pull request Sep 11, 2019
Merged
@zware zware merged commit aa92927 into python:master Sep 11, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Sep 11, 2019

Thanks @zooba for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@zooba @miss-islington
bpo-33166: Change os.cpu_count to return active (real) processors (py…
a9475d6 
…thonGH-15949)

(cherry picked from commit aa92927)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Sep 11, 2019

GH-15979 is a backport of this pull request to the 3.8 branch.

@zooba zooba deleted the bpo-33166 branch September 11, 2019 15:16
miss-islington added a commit that referenced this pull request Sep 11, 2019
@miss-islington @zooba
bpo-33166: Change os.cpu_count to return active (real) processors (GH…
43ee0e2 
…-15949)

(cherry picked from commit aa92927)

Co-authored-by: Steve Dower <steve.dower@python.org>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@zooba @DinoV
bpo-33166: Change os.cpu_count to return active (real) processors (py…
71dc9e0 
…thonGH-15949)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes

Assignees

No one assigned

Labels

OS-windows type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zooba @bedevere-bot @miss-islington @zware @the-knights-who-say-ni