Doc: Use walrus operator in example. #15934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @JulienPalard for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Sorry, @JulienPalard and @matrixise, I could not cleanly backport this to |
|
Thanks @JulienPalard for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Sorry @JulienPalard and @matrixise, I had trouble checking out the |
matrixise
pushed a commit
to matrixise/cpython
that referenced
this pull request
Sep 11, 2019
(cherry picked from commit e1d455f) Co-authored-by: Julien Palard <julien@palard.fr>
|
GH-15936 is a backport of this pull request to the 3.8 branch. |
matrixise
added a commit
that referenced
this pull request
Sep 11, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Sep 12, 2019
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #11441 (review), but I did in two steps so the first could be backported to 3.7 where the example was not working, and this second step for the 3.8 doc with the walrus.
Automerge-Triggered-By: @matrixise