Repository navigation
[3.14] gh-159185: Document that PyMarshal_WriteObjectToFile can silently truncate before 3.16 (GH-159201) - #159203
Merged
Conversation
…ly truncate before 3.16 (pythonGH-159201) pythongh-159185: Document that the PyMarshal file writers can fail silently before 3.16 In Python 3.15 and earlier, PyMarshal_WriteObjectToFile() ignores most marshalling errors and all I/O errors: it returns without setting the error indicator after writing only part of the data. PyMarshal_WriteLongToFile() ignores I/O errors in the same way. That was fixed in 3.16 by pythongh-155907, which is not backported. Tell the users of the older versions so that they can check what was written. (cherry picked from commit b3714a5) Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
bedevere-app
Bot
added
awaiting review
docs
gpshead
enabled auto-merge (squash)
October 11, 2026 21:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-159185: Document that the PyMarshal file writers can fail silently before 3.16
In Python 3.15 and earlier, PyMarshal_WriteObjectToFile() ignores most
marshalling errors and all I/O errors: it returns without setting the
error indicator after writing only part of the data.
PyMarshal_WriteLongToFile() ignores I/O errors in the same way. That
was fixed in 3.16 by gh-155907, which is not backported. Tell the users
of the older versions so that they can check what was written.
(cherry picked from commit b3714a5)
Co-authored-by: Gregory P. Smith 68491+gpshead@users.noreply.github.com