Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37798: Fix _statistics module doc #15546

Merged
merged 2 commits into from
Sep 3, 2019
Merged

bpo-37798: Fix _statistics module doc #15546

merged 2 commits into from
Sep 3, 2019

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Aug 27, 2019 •
edited by bedevere-bot
Loading

@corona10
Copy link
Member Author

corona10 commented Aug 27, 2019 •
edited
Loading

@rhettinger
I found my mistake from the first patch. Module doc should be updated. Please take a look.
Python3.8 needs a backport patch which was affected by #15266
(There was a mistake in using the clinic tool for the first time.)

@corona10 corona10 requested a review from rhettinger September 1, 2019 23:13
@corona10
Copy link
Member Author

corona10 commented Sep 3, 2019

@rhettinger ping

taleinat
taleinat requested changes Sep 3, 2019
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@corona10
Copy link
Member Author

corona10 commented Sep 3, 2019

@taleinat Thank you for the review. I've updated the PR :)

@taleinat
Copy link
Contributor

taleinat commented Sep 3, 2019

@corona10, great!

FYI, in the future, if you include "I have made the requested changes; please review again" in your comment, our Bedevere bot will understand, change the status labels accordingly and mention the relevant core devs.

taleinat
taleinat approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taleinat taleinat merged commit 0cf832a into python:master Sep 3, 2019
@miss-islington
Copy link
Contributor

Thanks @corona10 for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-15660 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 3, 2019
@corona10 @miss-islington
bpo-37798: Fix _statistics module doc (pythonGH-15546)
e1c3ad1 
(cherry picked from commit 0cf832a)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@corona10 corona10 deleted the bpo-37798 branch September 3, 2019 09:42
taleinat pushed a commit that referenced this pull request Sep 3, 2019
@miss-islington @corona10 @taleinat
bpo-37798: Fix _statistics module doc (GH-15546)
58067d2 
(cherry picked from commit 0cf832a)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@corona10 @lisroach
bpo-37798: Fix _statistics module doc (pythonGH-15546)
805e516
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@corona10 @DinoV
bpo-37798: Fix _statistics module doc (pythonGH-15546)
8fcbbb6
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@corona10 @websurfer5
bpo-37798: Fix _statistics module doc (pythonGH-15546)
69d15fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat taleinat approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @bedevere-bot @taleinat @miss-islington @the-knights-who-say-ni