PCbuild/build.bat: Add note about using msbuild response file. #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a response file will eliminate the headache associated with batch argument/quote processing. For example I unsucessfully compiled python with visualcpptools when specifying VSInstallDir in the batch file (cannot find vcruntime.h) ```batch build.bat -p x64 -e -M --no-tkinter "/p:VCInstallDir=%VCInstallDir%" ``` but it build successfully when specifying it in a response file msbuild.rsp: ``` /p:VCInstallDir=%VCInstallDir% ```
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a response file will eliminate the headache associated with batch argument/quote processing.
For example I unsuccessfully compiled python with visualcpptools when specifying VSInstallDir in the batch file (cannot find vcruntime.h)
build.bat -p x64 -e -M --no-tkinter "/p:VCInstallDir=%VCInstallDir%"but it built successfully when specifying it in a response file
msbuild.rsp: