Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Keep the venv/* exclude pattern. #15229

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

JulienPalard
Copy link
Member

In case it has been previously created.

In case it has been previously created.
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington
Copy link
Contributor

Thanks @JulienPalard for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@bedevere-bot
Copy link

GH-15502 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 26, 2019
In case it has been previously created.
(cherry picked from commit 73e0549)

Co-authored-by: Julien Palard <julien@palard.fr>
@miss-islington
Copy link
Contributor

Thanks @JulienPalard for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-15503 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 26, 2019
In case it has been previously created.
(cherry picked from commit 73e0549)

Co-authored-by: Julien Palard <julien@palard.fr>
miss-islington added a commit that referenced this pull request Aug 26, 2019
In case it has been previously created.
(cherry picked from commit 73e0549)

Co-authored-by: Julien Palard <julien@palard.fr>
miss-islington added a commit that referenced this pull request Aug 26, 2019
In case it has been previously created.
(cherry picked from commit 73e0549)

Co-authored-by: Julien Palard <julien@palard.fr>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
In case it has been previously created.
@JulienPalard JulienPalard deleted the doc-keep-venv-excluded branch October 22, 2019 16:19
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
In case it has been previously created.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
In case it has been previously created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants