[3.8] bpo-30088: Document that existing dir structure isn't verified by mailbox.Maildir (GH-1163) #14749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lbox.Maildir (pythonGH-1163) Hi, I've faced an issue w/ `mailbox.Maildir()`. The case is following: 1. I create a folder with `tempfile.TemporaryDirectory()`, so it's empty 2. I pass that folder path as an argument when instantiating `mailbox.Maildir()` 3. Then I receive an exception happening because "there's no such file or directory" (namely `cur`, `tmp` or `new`) during interaction with Maildir **Expected result:** subdirs are created during `Maildir()` instance creation. **Actual result:** subdirs are assumed as existing which leads to exceptions during use. **Workaround:** remove the actual dir before passing the path to `Maildir()`. It will be created automatically with all subdirs needed. **Fix:** This PR. Basically it adds creation of subdirs regardless of whether the base dir existed before. https://bugs.python.org/issue30088 (cherry picked from commit e441847) Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
bedevere-bot
added
type-bug
asvetlov
approved these changes
Jul 13, 2019
Contributor
Author
|
@webknjaz: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@webknjaz: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've faced an issue w/
mailbox.Maildir(). The case is following:tempfile.TemporaryDirectory(), so it's emptymailbox.Maildir()cur,tmpornew) during interaction with MaildirExpected result: subdirs are created during
Maildir()instance creation.Actual result: subdirs are assumed as existing which leads to exceptions during use.
Workaround: remove the actual dir before passing the path to
Maildir(). It will be created automatically with all subdirs needed.Fix: This PR. Basically it adds creation of subdirs regardless of whether the base dir existed before.
https://bugs.python.org/issue30088
(cherry picked from commit e441847)
Co-authored-by: Sviatoslav Sydorenko wk@sydorenko.org.ua
https://bugs.python.org/issue30088