Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-18374: fix tests to check the correct thing about line numbers #14659

Merged
merged 1 commit into from
Jul 9, 2019
Merged

bpo-18374: fix tests to check the correct thing about line numbers #14659

merged 1 commit into from
Jul 9, 2019

Conversation

cfbolz
Copy link
Contributor

@cfbolz cfbolz commented Jul 9, 2019 •
edited by bedevere-bot
Loading

@ilevkivskyi here's the promised fix.

Should I also try to do the backport to 3.7? (the automated merging fails because the end_lineno and end_col_offset didn't exist in 3.7).

https://bugs.python.org/issue18374

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jul 9, 2019
ilevkivskyi
ilevkivskyi approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ilevkivskyi ilevkivskyi merged commit 430a9f4 into python:master Jul 9, 2019
@miss-islington
Copy link
Contributor

Thanks @cfbolz for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2019
@cfbolz @miss-islington
bpo-18374: fix tests to check the correct thing about line numbers (p…
f1e7018 
…ythonGH-14659)

(cherry picked from commit 430a9f4)

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
@bedevere-bot
Copy link

GH-14672 is a backport of this pull request to the 3.8 branch.

@ilevkivskyi
Copy link
Member

@cfbolz

Should I also try to do the backport to 3.7?

I don't think it is worth spending some manual work on the backport. Fixing it in 3.8 is already good enough.

ilevkivskyi pushed a commit that referenced this pull request Jul 9, 2019
@miss-islington @cfbolz @ilevkivskyi
bpo-18374: fix tests to check the correct thing about line numbers (G…
68bd9c5 
…H-14659) (GH-14672)

(cherry picked from commit 430a9f4)

Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@cfbolz @lisroach
bpo-18374: fix tests to check the correct thing about line numbers (p…
9ec883f 
…ythonGH-14659)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@cfbolz @DinoV
bpo-18374: fix tests to check the correct thing about line numbers (p…
2bdf755 
…ythonGH-14659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cfbolz @miss-islington @bedevere-bot @ilevkivskyi @the-knights-who-say-ni